Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacsclient: remove Cask #171870

Merged
merged 1 commit into from
Apr 21, 2024
Merged

emacsclient: remove Cask #171870

merged 1 commit into from
Apr 21, 2024

Conversation

krehel
Copy link
Member

@krehel krehel commented Apr 21, 2024

This Cask looks to be a mistake. emacsclient is shipped with Emacs.

This emacsclient was being pulled from a repository that, while hasn't been updated in many years, is hosting the source for a Chrome/Firefox extension to use with org-mode in Emacs. It seems it was added for some level of convenience.

Either way, this would not be a canonical way to install emacsclient as it is neither the authoritative source of the software, nor updated. The original software this was intended to be for (org-capture-extension) can be installed through the appropriate web browser store.

Signed-off-by: Justin Krehel <[email protected]>
@SMillerDev
Copy link
Member

Maybe we disable it first so people get a warning ?

@krehel
Copy link
Member Author

krehel commented Apr 21, 2024

I thought as well. Could do, but utlimately this software shouldn't be here.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@p-linnane p-linnane merged commit 51a5124 into master Apr 21, 2024
10 checks passed
@p-linnane p-linnane deleted the emacsclient-remove branch April 21, 2024 20:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants