Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brightintosh: deprecate #170884

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

niklasr22
Copy link
Contributor

Removes the brightintosh cask because I can no longer provide the prebuilt application at this time.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@niklasr22 niklasr22 changed the title Removes brightintosh cask Remove BrightIntosh Cask Apr 8, 2024
@daeho-ro
Copy link
Member

daeho-ro commented Apr 9, 2024

I think the cask can be disabled but not simply deleted.

install: 100 (30 days), 229 (90 days), 334 (365 days)

@bevanjkay
Copy link
Member

@niklasr22 Can you please explain the situation a bit more? I can see that the latest version is still available from - https://c.brightintosh.de/updates/BrightIntosh_v1.6.1.dmg
If development has ceased since this release, we would be better to use deprecate with a reason of :discontinued.

@niklasr22
Copy link
Contributor Author

@bevanjkay Development is still active. For now I want to only distribute the built application through Apples App Store as donations didn't cover the costs of providing notarized builds.

@bevanjkay
Copy link
Member

@niklasr22 No worries, thanks for the update. We should still use the deprecate stanza, but the reason can be :moved_to_mas so that users are pointed in the appropriate direction.

@chenrui333
Copy link
Member

we dont do straight removal at best, I will update this PR to use :moved_to_mas like @bevanjkay said.

@chenrui333 chenrui333 changed the title Remove BrightIntosh Cask brightintosh: deprecate Apr 11, 2024
@krehel krehel merged commit a8d411c into Homebrew:master Apr 11, 2024
9 checks passed
@niklasr22
Copy link
Contributor Author

Thank you @chenrui333! Sorry I couldn't find time yet.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants