Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BetterTouchTool Cask with new release location #16402

Closed
wants to merge 1 commit into from
Closed

Updated BetterTouchTool Cask with new release location #16402

wants to merge 1 commit into from

Conversation

t3dotgg
Copy link

@t3dotgg t3dotgg commented Jan 6, 2016

BetterTouchTool's releases are now at a new address. This only applies for versions 1.5 and greater, which have the same compatibility as the 1.49 release that 1.5 replaces

@Amorymeltzer
Copy link
Contributor

You'll need to update the sha256, I'm getting f6408c0ba48588cd547bef4abdcfd723af5133af141f9f7a146d9ee7721f86e6. Also, from the appcast this appears to be version 1.5b, although it appears previous versions may not be kept online; this may need to move to :latest?

@jawshooah Did travis run brew cask audit? I don't think I see it and this should've died on the --download.

@t3dotgg
Copy link
Author

t3dotgg commented Jan 6, 2016

My mistake, pushed the wrong commit. Will fix when I get home

@t3dotgg t3dotgg closed this Jan 6, 2016
@jawshooah
Copy link
Contributor

@Amorymeltzer because RuboCop failed the build (unnecessary double-quotes) before we got to the audit.

@Amorymeltzer
Copy link
Contributor

@jawshooah Ahh right, duh. I think I thought the recent configuration put the cask-breaking checks would first, dunno why.

@jawshooah
Copy link
Contributor

That's probably a good idea, though. PR incoming.

@t3dotgg
Copy link
Author

t3dotgg commented Jan 6, 2016

@Amorymeltzer 's conjectures about older versions is true, they are no longer kept online and using :latest for this Cask makes more sense

@vitorgalvao
Copy link
Member

Actually, since this has an appcast, it makes no sense to have it as :latest. We still prefer versioned urls since we can shasum them, and the appcast will make updating easier in the future, and that’s no longer a “someday down the line, who knows when”, since we now have a plan (see the script/bot section, I plan to start making something soon).

PR for update.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants