Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Rake tasks #16367

Merged
merged 5 commits into from
Jan 5, 2016
Merged

Updates to Rake tasks #16367

merged 5 commits into from
Jan 5, 2016

Conversation

jawshooah
Copy link
Contributor

  • Use pry in console task for nicer formatting and debugging tools
  • Move man page generation to man rake task
  • Reorganize test tasks
    • Move rspec and minitest tasks under the test namespace
    • Create separate coverage task for generating coverage reports from tests

@jawshooah
Use pry in rake console task
f023072 
pry is a *much* better REPL than irb, with much nicer formatting
and debugging tools to boot!
@jawshooah
Add rake task to generate man page
5630893
@jawshooah
Include 'bundle exec' in instructions for running tests
a243050
@jawshooah
Reorganize rake testing tasks
0c54810 
* Move 'rspec' and 'minitest' tasks under the 'test' namespace
* Create separate 'coverage' task for generating coverage reports
  from tests
@jawshooah jawshooah added enhancement core Issue with Homebrew itself rather than with a specific cask. labels Jan 4, 2016
@jawshooah jawshooah added the awaiting maintainer feedback Issue needs response from a maintainer. label Jan 5, 2016
@adidalal
Copy link
Contributor

adidalal commented Jan 5, 2016

Don't know enough about Ruby testing to have an opinion either way, but LGTM.

Why is the seed needed?

@jawshooah
Copy link
Contributor Author

Why is the seed needed?

There's some temporal dependency in our integration tests that requires certain tests be run before others, and it's been there for a long time (#5037, #5064, #5613, #6611, #8871). Nobody has put in the time to root it out yet.

jawshooah added a commit that referenced this pull request Jan 5, 2016
@jawshooah
Merge pull request #16367 from jawshooah/rake-tasks
205d9e1 
Updates to Rake tasks
@jawshooah jawshooah merged commit 205d9e1 into Homebrew:master Jan 5, 2016
@jawshooah jawshooah deleted the rake-tasks branch January 5, 2016 04:16
@jawshooah jawshooah removed the awaiting maintainer feedback Issue needs response from a maintainer. label Jan 5, 2016
@miccal miccal removed core Issue with Homebrew itself rather than with a specific cask. enhancement labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawshooah @adidalal @miccal