Update 39 casks to use versioned urls (Batch 1, A-K) #13115
Conversation
|
|
||
| url 'https://macrabbit.com/espresso/get/' | ||
| appcast 'https://update.macrabbit.com/espresso/2.2.3.xml', | ||
| url "https://s3.amazonaws.com/macrabbit/downloads/Espresso%20#{version}.zip" |
There was a problem hiding this comment.
The comment # amazonaws.com is the official download host per the vendor homepage is missing. Even if there is a redirect from official URL https://macrabbit.com/espresso/get/.
|
@scribblemaniac Where are you finding all these, even? Many of them are quite hard to find, and I sincerely worry these changes actually make them harder to upgrade. |
|
@vitorgalvao The weren't all that difficult for me to find. They are all found either on a homepage or in an appcast feed. Certainly latest casks are easier to upgrade, but I wasn't the one who decided that this was a good idea. Perhaps you need a refresher on why this decision was made: #1021. |
|
No need, I remember the discussion well. I was against it for a long time, until being convinced. Funnily enough, plans for In the previous comment I didn’t mean “upgrade” as in “upgrading installed apps”, but as in “updating the cask files themselves”, i.e. if these links were hard to find, other collaborators wouldn’t find them and casks would remain frozen in an older version. If those were easy to find after all, no big deal. |
|
Maintainers shouldn't have to worry about finding the links though, all they should need to do is modify the version string. If the new version doesn't work with these links, they can simply use whatever link is on the homepage and assume that this link format is not being supported anymore. |
|
Agreed. |
scribblemaniac
force-pushed
the
switch-versioning-1
branch
2 times, most recently
from
6373483 to
244010d
Compare
scribblemaniac
force-pushed
the
switch-versioning-1
branch
from
244010d to
67ed752
Compare
|
Okay, I'm pretty sure I've fixed everything brought up so far and then some. Thank you @vitorgalvao and @victorpopkov for having patience with me. I don't know why I keep making stupid mistakes like these, hopefully the next time will go smoother. |
|
Everything looks good. Thank you for all the patience in making all the changes and for the contribution of course. |
Update 39 casks to use versioned urls (Batch 1, A-K)
No description provided.