-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox nightly #1144
Firefox nightly #1144
Conversation
Please see #142, regarding this. |
Sorry, noob here with brew cask and pull requests. Didn't see this was already being discussed. |
No problem, happens from time to time. The issue has been there for some time, if you have some new input, it’s very welcome. |
Just a thought, but regarding the nightly build apps, wouldn't it be smart for now to just include theses as casks until the entire situation is solved so that people have these available? |
We’re not sure, which is why the pull requests for these apps linger, instead of being outright rejected. Nightly builds are themselves a pain, and we haven’t even decided on how to manage those. |
I'm amenable to this idea for stop-gap inclusion of these apps since it seems like there is sufficient demand for them. |
@phinze I think thats a great temporary solution. Ideally there would be a better format as the forums have suggested, but just to give people the ability to download now, seems like a great idea. |
@apermanentwreck Can you pick out the firefox commit? It's currently bundled with webkit/merge branch commits. |
@nanoxd, will do. |
@nanoxd reverted/removed the Webkit merge. |
@apermanentwreck Can you squash the commits? |
How do I do that? |
@apermanentwreck See this blog article Once you rebase, you'll have to do a force push. |
Does that work? |
No, you added another merge commit. We can close this PR and reopen with a solo commit for this cask 😄 |
Sorry, this is all relatively new to me and I keep merging in the master branch because its what I'm used to doing. |
So what do I need to do to get this exactly as you guys apparently need it? |
@chrisopedia No worries! The easiest way is to close this pull request, create a new branch with the firefox-nightly cask, commit your changes, open a new pull request, and merge! |
In hopes that the firefox nightly issue will be eventually figured out, this is an attempt to patch the existing whole of missing nightly apps.
I think I've surely fucked this up, so I'm going to do some research and then put this together properly. |
You have to start from scratch. Here are the steps to follow:
|
Done. |
Credit: @apermanentwreck Closes: Homebrew#1471 Homebrew#1144
Add the firefox nightly app from http://nightly.mozilla.org