Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox nightly #1144

Closed
wants to merge 4 commits into from
Closed

Firefox nightly #1144

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2013

Add the firefox nightly app from http://nightly.mozilla.org

@vitorgalvao
Copy link
Contributor

Please see #142, regarding this.

@ghost
Copy link
Author

ghost commented Oct 6, 2013

Sorry, noob here with brew cask and pull requests. Didn't see this was already being discussed.

@vitorgalvao
Copy link
Contributor

No problem, happens from time to time. The issue has been there for some time, if you have some new input, it’s very welcome.

@ghost
Copy link
Author

ghost commented Oct 7, 2013

Just a thought, but regarding the nightly build apps, wouldn't it be smart for now to just include theses as casks until the entire situation is solved so that people have these available?

@vitorgalvao
Copy link
Contributor

We’re not sure, which is why the pull requests for these apps linger, instead of being outright rejected. Nightly builds are themselves a pain, and we haven’t even decided on how to manage those.

@phinze
Copy link
Contributor

phinze commented Oct 8, 2013

Just a thought, but regarding the nightly build apps, wouldn't it be smart for now to just include theses as casks until the entire situation is solved so that people have these available?

I'm amenable to this idea for stop-gap inclusion of these apps since it seems like there is sufficient demand for them.

@ghost
Copy link
Author

ghost commented Oct 8, 2013

@phinze I think thats a great temporary solution. Ideally there would be a better format as the forums have suggested, but just to give people the ability to download now, seems like a great idea.

@nanoxd
Copy link
Contributor

nanoxd commented Oct 23, 2013

@apermanentwreck Can you pick out the firefox commit? It's currently bundled with webkit/merge branch commits.

@ghost
Copy link
Author

ghost commented Oct 23, 2013

@nanoxd, will do.

@iamnewton
Copy link
Contributor

@nanoxd reverted/removed the Webkit merge.

@nanoxd
Copy link
Contributor

nanoxd commented Nov 3, 2013

@apermanentwreck Can you squash the commits? :neckbeard:

@ghost
Copy link
Author

ghost commented Nov 3, 2013

How do I do that?

@nanoxd
Copy link
Contributor

nanoxd commented Nov 3, 2013

@apermanentwreck See this blog article Once you rebase, you'll have to do a force push.

@iamnewton
Copy link
Contributor

Does that work?

@nanoxd
Copy link
Contributor

nanoxd commented Nov 4, 2013

No, you added another merge commit. We can close this PR and reopen with a solo commit for this cask 😄

@iamnewton
Copy link
Contributor

Sorry, this is all relatively new to me and I keep merging in the master branch because its what I'm used to doing.

@iamnewton
Copy link
Contributor

So what do I need to do to get this exactly as you guys apparently need it?

@nanoxd
Copy link
Contributor

nanoxd commented Nov 4, 2013

@chrisopedia No worries! The easiest way is to close this pull request, create a new branch with the firefox-nightly cask, commit your changes, open a new pull request, and merge!

Newton added 2 commits November 3, 2013 17:46
In hopes that the firefox nightly issue will be eventually figured out,
this is an attempt to patch the existing whole of missing nightly apps.
@iamnewton
Copy link
Contributor

I think I've surely fucked this up, so I'm going to do some research and then put this together properly.

@nanoxd
Copy link
Contributor

nanoxd commented Nov 4, 2013

You have to start from scratch. Here are the steps to follow:

  1. On your machine, run git checkout master
  2. Create a new branch using git checkout -b FirefoxNightly
  3. Verify that the firefox-nightly cask does not exist.
  4. Create a new firefox-nightly cask and open in your favorite editor.
  5. Update the URL for the alpha to http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/firefox-28.0a1.en-US.mac.dmg
  6. Change the version
  7. Remove the checksum (SHA1) and set it to no_checksum
  8. Push your changes to your fork of brew-cask and open a new PR

@iamnewton
Copy link
Contributor

Done.

nanoxd added a commit that referenced this pull request Nov 4, 2013
Credit: @apermanentwreck
Closes: #1471 #1144
@nanoxd nanoxd closed this Nov 4, 2013
kevinSuttle pushed a commit to kevinSuttle/homebrew-cask that referenced this pull request Dec 8, 2013
Credit: @apermanentwreck
Closes: Homebrew#1471 Homebrew#1144
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants