Cask cleanup command misplaced result

[ngocphamm]

Running brew cask cleanup results in the following result.

==> Removing dead symlinks
/Library/Caches/Homebrew/Casks/hr-0.3.6.zip
==> Removing cached downloads
Nothing to do

I think the part about hr zip should be under "Removing cached downloads".

[rolandwalker]

Hi! Thanks for the report!

In this case, /Library/Caches/Homebrew/Casks/hr-0.3.6.zip actually was a dead symlink. I'm not sure how to display it better. Showing the target of the symlink might confuse people, because the link target of a dead link is a nonexistent file.

[ngocphamm]

Not sure why it would be a dead symlink, actually. However, it's okay up to your decision. I just found it a bit confusing and think it could be a bug there. Thank you for looking into that.

[rolandwalker]

Homebrew-cask creates tracker symlinks because (parent command) Homebrew's brew cleanup does not know how to clean up our files. (#2759)

Would it be helpful to the user if we added the word "tracker"?

==> Removing dead tracker symlinks
/Library/Caches/Homebrew/Casks/hr-0.3.6.zip
==> Removing cached downloads
Nothing to do

or is that just more confusing?

Since the filesystem is being changed, I definitely want the user to be informed.

[ngocphamm]

Either way will need clarification on the documentation of the command or so, in my opinion. If it's there (and clearly, somehow) it would be good to leave it in current state. Or maybe it's not that important, just me feeling a bit lost. 😄

[vitorgalvao]

If you want to submit a PR to make the documentation clearer, @ngocphamm, we can review it. This isn’t a common complaint, though (don’t remember ever seeing it repeated).