You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It was an absolutely terrible idea to expose user-facing scripts that automatically generate GitHub issues and PRs for outdated casks. These scripts were always intended to be run only by maintainers, and even then only until we had the means to automate them, but no safeguards were ever put in place to ensure that non-maintainers did not run them and spam the repo with issues.
The recent spate of "outdated cask" issues across this repo, homebrew-versions, and homebrew-fonts have made it clear that we need to either build these safeguards into the scripts, or abandon them completely. As far as I can tell, they haven't been run in months, so I don't think it would be a great loss to remove them, at least until we have a better scheme in place to automatically update casks based on appcast.
@caskroom/maintainers, thoughts?
Side note, if you're interested, here's the script I used to remediate this:
I’m fine with removing them. Now they have been in place for so long — and due to their usage and lack of usage — we have a better grasp for what needs to change about them.
I have for some time in my head a forming system for this, but it’ll take some time and work to flesh out.
In the meantime, I think having a single find_and_fix script that will only generate PRs and can be run by maintainers and users alike might be a good fit.
It was an absolutely terrible idea to expose user-facing scripts that automatically generate GitHub issues and PRs for outdated casks. These scripts were always intended to be run only by maintainers, and even then only until we had the means to automate them, but no safeguards were ever put in place to ensure that non-maintainers did not run them and spam the repo with issues.
The recent spate of "outdated cask" issues across this repo, homebrew-versions, and homebrew-fonts have made it clear that we need to either build these safeguards into the scripts, or abandon them completely. As far as I can tell, they haven't been run in months, so I don't think it would be a great loss to remove them, at least until we have a better scheme in place to automatically update casks based on appcast.
@caskroom/maintainers, thoughts?
Side note, if you're interested, here's the script I used to remediate this:
The text was updated successfully, but these errors were encountered: