Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: Missing API keys, Chromium features are disabled #193814

Closed
6 tasks done
Neved4 opened this issue Dec 1, 2024 · 4 comments
Closed
6 tasks done

chromium: Missing API keys, Chromium features are disabled #193814

Neved4 opened this issue Dec 1, 2024 · 4 comments

Comments

@Neved4
Copy link

Neved4 commented Dec 1, 2024

This is not a command issue, could be considered more of a bug in how Chromium is currently shipped. See Debian Bug report below.

Verification

Description of issue

Currently, Chromium shipped via Homebrew lacks Google API keys, which disables certain features such as Safe Browsing, Geolocation, and Spelling Suggestions. See:

The key in question allows access to nine separate Google services including Spelling, Suggest, Translate, Geolocation, Safe Browsing, and so on. While some of those features could be considered optional, losing them would certainly degrade users' experience compared to Chrome browser users—or even Firefox users—in many cases. It's a little strange to see a feature added that requires a magic key in order to use it, but the restrictions on what can be done with the APIs and keys makes it all the more worrisome.

Debian also had this issue and seem to have fixed it 10 years ago. We could either reuse Debian API keys or get Google to assign a set of keys for the Homebrew project.

See also

The Chromium Project - API Keys
LWN.net - Chromium API keys on Debian
Debian Bug Tracker - #748867
Debian API keys

Command that failed

N/A

Output of command with --verbose --debug

N/A

Output of brew doctor and brew config

N/A

Output of brew tap

N/A
@SMillerDev
Copy link
Member

That page from the chromium project is very specific. It mentions that anyone who did not accept the ToS for these keys is not allowed to use them. So I don't think Homebrew should go against that rule.

@Neved4
Copy link
Author

Neved4 commented Dec 1, 2024

Sounds good, it'd be much better to get Google to assign a set of keys for Homebrew.

@Neved4
Copy link
Author

Neved4 commented Dec 2, 2024

Closing based on the discussions in #193814 (comment) and #193815 (comment). Thx again!

@Neved4 Neved4 closed this as completed Dec 2, 2024
@Neved4
Copy link
Author

Neved4 commented Dec 2, 2024

For anyone stumbling across this on macOS, here's a rundown:

  1. With launchctl setenv, you can set the values for a current session.
  2. To persist across reboots, you can use a launchd script.
  3. The above will set the variables globally. Setting them on a per-app basis will ensure isolation from other processes. To do this, you can feed the values into Info.plist with plutil, but note it will not survive app upgrades.
  4. You can also edit Info.plist manually with an editor, and add the values after LSEnvironment.

G'luck!

@Neved4 Neved4 reopened this Dec 7, 2024
@Neved4 Neved4 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants