Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit --download should check appcast as well #16529

Closed
3 tasks done
vitorgalvao opened this issue Jan 7, 2016 · 1 comment
Closed
3 tasks done

audit --download should check appcast as well #16529

vitorgalvao opened this issue Jan 7, 2016 · 1 comment

Comments

@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 7, 2016

This is a typical version bump PR:

image

Which means something (now) important and (currently) unchecked might be lurking under.

image

Having to do this for every PR will likely makes us miss some.

Solution: make Travis check for it. Better solution: make audit do the work, since it seems appropriate. Also, we’ll get audit_modified_casks for free.

It makes sense to only check for it on audit --download, since otherwise the cask might be correct. It should do three checks:

  • Does appcast return a 200 HTTP response code?
  • Is checkpoint: different than e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 (empty string)?
  • Is checkpoint: correct?
@vitorgalvao vitorgalvao added enhancement core Issue with Homebrew itself rather than with a specific cask. labels Jan 7, 2016
@adidalal
Copy link
Contributor

adidalal commented Jan 7, 2016

https://github.com/caskroom/homebrew-cask/blob/master/lib/hbc/audit.rb

(2) is already checked for.

(1) and (3) could be done by extending check_download, as technically the same thing is already done for url

@jawshooah jawshooah self-assigned this Jan 9, 2016
@adidalal adidalal mentioned this issue Jan 10, 2016
8 tasks
@vitorgalvao vitorgalvao mentioned this issue Apr 4, 2016
3 tasks
@miccal miccal removed core Issue with Homebrew itself rather than with a specific cask. enhancement ready to implement labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants