-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audit --download
should check appcast as well
#16529
Comments
vitorgalvao
added
enhancement
core
Issue with Homebrew itself rather than with a specific cask.
labels
Jan 7, 2016
https://github.com/caskroom/homebrew-cask/blob/master/lib/hbc/audit.rb (2) is already checked for. (1) and (3) could be done by extending |
This was referenced Jan 12, 2016
1 task
miccal
removed
core
Issue with Homebrew itself rather than with a specific cask.
enhancement
ready to implement
labels
Dec 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a typical version bump PR:
Which means something (now) important and (currently) unchecked might be lurking under.
Having to do this for every PR will likely makes us miss some.
Solution: make Travis check for it. Better solution: make
audit
do the work, since it seems appropriate. Also, we’ll getaudit_modified_casks
for free.It makes sense to only check for it on
audit --download
, since otherwise the cask might be correct. It should do three checks:appcast
return a 200 HTTP response code?checkpoint:
different thane3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
(empty string)?checkpoint:
correct?The text was updated successfully, but these errors were encountered: