Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Update firefox-aurora.rb #359

Closed
wants to merge 1 commit into from
Closed

Conversation

joeyhoer
Copy link

@joeyhoer joeyhoer commented Aug 9, 2014

SHA hash updated

SHA hash updated
@rolandwalker
Copy link
Contributor

As this build changes nightly, the SHA will always break.

We should change this Cask to use sha256 :no_check, but then there is an audit test that will claim this is inconsistent because a version string exists. We will have to rewrite it without a version.

@caskroom/maintainers, I've been thinking of making the audit test only one-way: version 'latest' does demand sha256 :no_check, but the opposite form is useful. Reasons:

  • avoid throwing away version information which is needed for upgrade functionality. (If the version is stored nowhere, it is not possible to know when an upgrade is due.)
  • clarity for authors: sha256 :no_check would simply mean what it says

We should also give users a --no-check command-line option.

@vitorgalvao
Copy link
Contributor

I’ll argue that sha256 :no_check in a cask with a version number will be less clear, not more. We don’t allow it currently, even making the build fail, and yet it is still something I’ve encountered multiple times, in submissions. Many of our contributors are first time contributors, as you’ve pointed out before, and those usually look at other casks for examples. Possibly the biggest source of errors was exactly in cases where some casks had slight deviations from others that otherwise looked similar. I say “was” because the more we standardise them with clearly defined rules and syntax, the less it happens.

I’m not claiming to have though of a better solution, though, I’ve tried before, unsuccessfully.

@hkim823
Copy link
Contributor

hkim823 commented Sep 5, 2014

A 👍 on the --no-check option if it's too much work to have the sha:no_check in the recipe not build properly.

@dallagi
Copy link

dallagi commented Oct 30, 2014

I think the best way to fix this cask would be to follow the same approach taken with the firefox-nightly cask, which has version set to ':latest' and sha256 set to ':no_check'.

@tapeinosyne
Copy link
Contributor

Supersed by #539. The matter of dealing with changing hashes is being discussed elsewhere.

iggyvolz pushed a commit to iggyvolz/homebrew-versions that referenced this pull request Jan 12, 2015
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants