Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

gmp: add arm64 compatibility patch#288

Merged
claui merged 1 commit intoHomebrew:masterfrom
claui:gmp-arm
Jul 6, 2020
Merged

gmp: add arm64 compatibility patch#288
claui merged 1 commit intoHomebrew:masterfrom
claui:gmp-arm

Conversation

@claui
Copy link
Contributor

@claui claui commented Jul 4, 2020

This commit consolidates the two patches proposed in Homebrew/homebrew-core#57315.

This commit consolidates the two patches proposed in
Homebrew/homebrew-core#57315.

Suggested-by: FX Coudert <fxcoudert@gmail.com>
@claui claui requested a review from fxcoudert July 4, 2020 12:14
@claui claui requested a review from a team July 5, 2020 10:57
@claui
Copy link
Contributor Author

claui commented Jul 5, 2020

Pinging @Homebrew/core for review, as this is blocking Homebrew/homebrew-core#57315.

I already double-checked that this consolidated patch works on arm64.

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a patch to me

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as long as these have been submitted upstream.

@claui
Copy link
Contributor Author

claui commented Jul 6, 2020

@MikeMcQuaid Sort of; we just owe them feedback on the latest update of this patch.

Update: done and acknowledged.

@claui claui closed this Jul 6, 2020
@claui claui reopened this Jul 6, 2020
@claui claui merged commit c53834b into Homebrew:master Jul 6, 2020
@claui claui deleted the gmp-arm branch July 6, 2020 12:41
@claui
Copy link
Contributor Author

claui commented Jul 6, 2020

Thanks @SMillerDev and @MikeMcQuaid for your feedback!

@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants