Skip to content

python: update virtualenv#9373

Merged
fxcoudert merged 1 commit intoHomebrew:masterfrom
fxcoudert:virtualenv
Dec 2, 2020
Merged

python: update virtualenv#9373
fxcoudert merged 1 commit intoHomebrew:masterfrom
fxcoudert:virtualenv

Conversation

@fxcoudert
Copy link
Member

@fxcoudert fxcoudert commented Dec 2, 2020

It seems without this, we're not picking up the latest pip version in our builds…

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Dec 2, 2020

Review period will end on 2020-12-03 at 08:56:55 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 2, 2020
@fxcoudert
Copy link
Member Author

fxcoudert commented Dec 2, 2020

Review period will end on 2020-12-03 at 08:56:55 UTC

I thought the review period didn't apply to simple version updates?

@reitermarkus
Copy link
Member

reitermarkus commented Dec 2, 2020

The review period applies to everything which is not marked critical.

@fxcoudert
Copy link
Member Author

fxcoudert commented Dec 2, 2020

From https://github.com/Homebrew/brew/blob/master/docs/Maintainer-Guidelines.md#give-time-for-other-maintainers-to-review:

PRs that are an "enhancement" to existing functionality i.e. not a fix to an open user issue/discussion, not a version bump, not a security fix, not a fix for CI failure, a usability improvement, a new feature, refactoring etc. should wait 24h Monday - Friday before being merged

So that's different from “critical”, in the common meaning of the word, isn't it?

@reitermarkus
Copy link
Member

reitermarkus commented Dec 2, 2020

Well, critical is kind of a catch-all. We could have multiple labels do the same thing, but I think critical can generally be used for anything.

@reitermarkus
Copy link
Member

reitermarkus commented Dec 2, 2020 •
edited
Loading

If you have any more thoughts on this, discuss here: #9224

Regarding this PR: Is this version bump unblocking another PR? If so, I'd argue it is critical.

@fxcoudert fxcoudert added the critical Critical change which should be shipped as soon as possible. label Dec 2, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 2, 2020
@BrewTestBot
Copy link
Contributor

BrewTestBot commented Dec 2, 2020 •
edited
Loading

Review period ended.

@fxcoudert
Copy link
Member Author

fxcoudert commented Dec 2, 2020

Yes it needs to go in before I test Homebrew/homebrew-core#66063

@fxcoudert fxcoudert merged commit 679ce18 into Homebrew:master Dec 2, 2020
@fxcoudert fxcoudert deleted the virtualenv branch December 2, 2020 10:20
@fxcoudert fxcoudert mentioned this pull request Dec 2, 2020
Closed
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@reitermarkus reitermarkus reitermarkus approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees

No one assigned

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fxcoudert @BrewTestBot @reitermarkus