Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: temporarily allow python3.9 rc #8742

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

dtrodrigues
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Temporarily allow the python 3.9 release candidate In support of Homebrew/homebrew-core#61163 so that the audit doesn't fail.

@dtrodrigues
Copy link
Member Author

Either there needs to be another allowlist for formulae that are allowed unstable but also don't yet exist, or the audit_spec test needs to be modified to ignore python 3.9 when checking to see if all of the formulae on the unstable allowlist exist, or maybe something else.
rspec ./test/dev-cmd/audit_spec.rb[3:43] # Homebrew::FormulaAuditor [email protected] formula exists

@dtrodrigues
Copy link
Member Author

I ended up making a new list for this case since it somehow needed to be separated from the other unstable formulae in Homebrew since it won't exist in Homebrew core for some time.

@MikeMcQuaid MikeMcQuaid merged commit 3cfa0f0 into Homebrew:master Sep 17, 2020
@MikeMcQuaid
Copy link
Member

Thanks @dtrodrigues!

@dtrodrigues dtrodrigues deleted the python39-rc branch September 21, 2020 03:07
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants