Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Library/Homebrew/extend/os/linux/diagnostic.rb
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def check_kernel_minimum_version
return unless OS::Linux::Kernel.below_minimum_version?

<<~EOS
Your Linux kernel #{OS::Linux::Kernel.version} is too old.
Your Linux kernel #{OS.kernel_version} is too old.
We only support kernel #{OS::Linux::Kernel.minimum_version} or later.
You will be unable to use binary packages (bottles).
#{please_create_pull_requests}
Expand Down
4 changes: 4 additions & 0 deletions Library/Homebrew/os.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ def self.linux?
RbConfig::CONFIG["host_os"].include? "linux"
end

def self.kernel_version
@kernel_version ||= Version.new(Utils.safe_popen_read("uname", "-r").chomp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

end

::OS_VERSION = ENV["HOMEBREW_OS_VERSION"]

if OS.mac?
Expand Down
11 changes: 1 addition & 10 deletions Library/Homebrew/os/linux/kernel.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,12 @@ module Linux
module Kernel
module_function

def version
return @version if @version

version = Utils.popen_read("uname", "-r").chomp
return Version::NULL unless version

@version = Version.new version
end

def minimum_version
Version.new "2.6.32"
end

def below_minimum_version?
version < minimum_version
OS.kernel_version < minimum_version
end
end
end
Expand Down
9 changes: 9 additions & 0 deletions Library/Homebrew/test/os/os_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# frozen_string_literal: true

describe OS do
describe ".kernel_version" do
it "is not empty" do
expect(described_class.kernel_version).not_to be_empty
end
end
end