Skip to content

Conversation

@EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
Copy link
Member

You could also check for an empty string in formulae.brew.sh output but I'm fine with this so: 👍 thanks again.

@EricFromCanada
Copy link
Member Author

Yes, that issue cropped up because I'd assumed the cask API would return null in that case as the formula API currently does.

@MikeMcQuaid
Copy link
Member

Gotcha. 👍 for consistency.

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants