-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Fix Java 1.8 requirement caveats #6035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As stated in homebrew-cask-versions#7253 [1], Java 1.8 is no longer freely available from Oracle. Users who wish to continue using Oracle JDK 1.8 will have to download and install it manually from Oracle’s website, which now requires registration. Alternatively, users can now install AdoptOpenJDK 8, a drop-in replacement for Oracle JDK 1.8. This commit fixes the caveat to reflect those changes. For compatibility reasons (homebrew-core formulas are largely untested with AdoptOpenJDK), the manual Oracle download will now be listed as the preferred choice. [1]: https://github.com/Homebrew/homebrew-cask-versions/issues/7253
|
What does |
|
@MikeMcQuaid That will error out because the We have deleted it to make sure existing installs are left untouched. |
|
@claui Gotcha. In that case I think we can unconditionally recommend AdoptOpenJDK 8 and we'll merge this PR when the CI images are updated to use it instead of |
|
@MikeMcQuaid Sounds good. Thanks for the pointer! |
|
@claui Oh, also I reckon we switch to the |
|
This just emerged from a brief internal discussion among maintainers (thanks @SMillerDev, @MikeMcQuaid, and @fxcoudert):
tl;dr We’re planning to endorse AdoptOpenJDK only. Closing this PR while I prepare an updated one. |
brew testskeeps returning with the error:Could not find json-2.2.0 in any of the sourcesbrew stylewith your changes locally? Returned with error:incompatible library version - /Users/claudia/Documents/dev/brew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/jaro_winkler-1.5.2/lib/jaro_winkler/jaro_winkler_ext.bundlebrew testswith your changes locally? See above; I tested all possible branches manually though.As stated in https://github.com/Homebrew/homebrew-cask-versions/issues/7253, Java 1.8 is no longer freely available from Oracle. Users who wish to continue using Oracle JDK 1.8 will have to download and install it manually from Oracle’s website, which now requires registration.
Alternatively, users can now install AdoptOpenJDK 8, a drop-in replacement for Oracle JDK 1.8. This commit fixes the caveat to reflect those changes.
For compatibility reasons (homebrew-core formulas are largely untested with AdoptOpenJDK), the manual Oracle download will now be listed as the preferred choice.
For the general case, the caveat now says:
For a formula that requires Java 1.8 or lower, the caveat now says: