Skip to content

tap: fix autobump logic for unofficial taps #19854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bevanjkay merged 2 commits into from
Apr 30, 2025
Merged

tap: fix autobump logic for unofficial taps #19854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a043e7b
tap: fix autobump logic for unofficial taps
botantony Apr 29, 2025
1791c2e
tap_auditor: do not audit `autobump.txt` in official taps
botantony Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Library/Homebrew/tap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,8 +987,10 @@ def self.tap_migration_oldnames(current_tap, name_or_token)
def autobump
autobump_packages = if core_cask_tap?
Homebrew::API::Cask.all_casks
else
elsif core_tap?
Homebrew::API::Formula.all_formulae
else
{}
end

@autobump ||= autobump_packages.select do |_, p|
Expand Down
3 changes: 2 additions & 1 deletion Library/Homebrew/tap_auditor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ def initialize(tap, strict:)
@tap_style_exceptions = tap.style_exceptions
@tap_pypi_formula_mappings = tap.pypi_formula_mappings
@tap_autobump = tap.autobump
@tap_official = tap.official?
@problems = []

@cask_tokens = tap.cask_tokens.map do |cask_token|
Expand Down Expand Up @@ -54,8 +55,8 @@ def audit_tap_formula_lists
check_formula_list_directory "audit_exceptions", @tap_audit_exceptions
check_formula_list_directory "style_exceptions", @tap_style_exceptions
check_formula_list "pypi_formula_mappings", @tap_pypi_formula_mappings
check_formula_list ".github/autobump.txt", @tap_autobump
check_formula_list "formula_renames", @formula_renames.values
check_formula_list ".github/autobump.txt", @tap_autobump unless @tap_official
end

sig { void }
Expand Down