bottle: reproducibility fixes.#15819
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Aug 4, 2023
MikeMcQuaid:bottle_reproducibility_fixes
Merged
bottle: reproducibility fixes.#15819MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:bottle_reproducibility_fixes
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:bottle_reproducibility_fixes
Conversation
MikeMcQuaid
added
the
critical
BrewTestBot
approved these changes
Aug 4, 2023
I noticed from https://github.com/Homebrew/homebrew-core/actions/runs/5751070010 that we're no longer creating reproducible bottles between macOS and Linux. All macOS checksums have changed but Linux ones have not. The main difference between the two platforms is the `gtar` version used so let's always just use the formula on both platforms. While we're here, clear up the ordering and comments a little on the reproducible `tar` arguments so that it's easier to compare with the reproducible builds archives documentation.
This was referenced Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed from https://github.com/Homebrew/homebrew-core/actions/runs/5751070010 that we're no longer creating reproducible bottles between macOS and Linux.
All macOS checksums have changed but Linux ones have not. The main difference between the two platforms is the
gtarversion used so let's always just use the formula on both platforms.While we're here, clear up the ordering and comments a little on the reproducible
tararguments so that it's easier to compare with the reproducible builds archives documentation.