Skip to content

resource_auditor: restore curl HTTP mirror auditing#12166

Merged
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:curl-http-mirror
Oct 5, 2021
Merged

resource_auditor: restore curl HTTP mirror auditing#12166
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:curl-http-mirror

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Oct 1, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We need brewed curl for functional HTTPS support, but can't currently install curl from source because there's HTTPS everywhere.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Oct 1, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Oct 1, 2021

Review period ended.

@Bo98 Bo98 force-pushed the curl-http-mirror branch from 6827bce to a07a74a Compare October 1, 2021 13:31
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, nice work restoring this.

@Bo98 Bo98 force-pushed the curl-http-mirror branch from a07a74a to 50a58f4 Compare October 3, 2021 21:17
@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Oct 3, 2021

The Linux dep tree seems very large.

@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Oct 3, 2021

curl
├── pkg-config
├── brotli
│   └── cmake
│       ├── ncurses
│       │   ├── pkg-config
│       │   └── gpatch
│       └── openssl@1.1
├── libidn2
│   ├── pkg-config
│   ├── gettext
│   │   ├── libxml2
│   │   │   ├── python@3.9
│   │   │   │   ├── pkg-config
│   │   │   │   ├── gdbm
│   │   │   │   ├── mpdecimal
│   │   │   │   ├── openssl@1.1
│   │   │   │   ├── readline
│   │   │   │   │   └── ncurses
│   │   │   │   │       ├── pkg-config
│   │   │   │   │       └── gpatch
│   │   │   │   ├── sqlite
│   │   │   │   │   ├── readline
│   │   │   │   │   │   └── ncurses
│   │   │   │   │   │       ├── pkg-config
│   │   │   │   │   │       └── gpatch
│   │   │   │   │   └── zlib
│   │   │   │   ├── xz
│   │   │   │   ├── bzip2
│   │   │   │   ├── expat
│   │   │   │   ├── libffi
│   │   │   │   ├── ncurses
│   │   │   │   │   ├── pkg-config
│   │   │   │   │   └── gpatch
│   │   │   │   ├── unzip
│   │   │   │   │   └── bzip2
│   │   │   │   └── zlib
│   │   │   ├── readline
│   │   │   │   └── ncurses
│   │   │   │       ├── pkg-config
│   │   │   │       └── gpatch
│   │   │   └── zlib
│   │   └── ncurses
│   │       ├── pkg-config
│   │       └── gpatch
│   └── libunistring
├── libssh2
│   ├── openssl@1.1
│   └── zlib
├── nghttp2
│   ├── pkg-config
│   ├── c-ares
│   │   └── cmake
│   │       ├── ncurses
│   │       │   ├── pkg-config
│   │       │   └── gpatch
│   │       └── openssl@1.1
│   ├── jemalloc
│   ├── libev
│   ├── openssl@1.1
│   ├── libxml2
│   │   ├── python@3.9
│   │   │   ├── pkg-config
│   │   │   ├── gdbm
│   │   │   ├── mpdecimal
│   │   │   ├── openssl@1.1
│   │   │   ├── readline
│   │   │   │   └── ncurses
│   │   │   │       ├── pkg-config
│   │   │   │       └── gpatch
│   │   │   ├── sqlite
│   │   │   │   ├── readline
│   │   │   │   │   └── ncurses
│   │   │   │   │       ├── pkg-config
│   │   │   │   │       └── gpatch
│   │   │   │   └── zlib
│   │   │   ├── xz
│   │   │   ├── bzip2
│   │   │   ├── expat
│   │   │   ├── libffi
│   │   │   ├── ncurses
│   │   │   │   ├── pkg-config
│   │   │   │   └── gpatch
│   │   │   ├── unzip
│   │   │   │   └── bzip2
│   │   │   └── zlib
│   │   ├── readline
│   │   │   └── ncurses
│   │   │       ├── pkg-config
│   │   │       └── gpatch
│   │   └── zlib
│   └── zlib
├── openldap
│   ├── openssl@1.1
│   └── util-linux
│       ├── asciidoctor
│       │   └── ruby
│       │       ├── pkg-config
│       │       ├── libyaml
│       │       │   ├── autoconf
│       │       │   │   ├── m4
│       │       │   │   └── perl
│       │       │   │       ├── berkeley-db
│       │       │   │       │   └── openssl@1.1
│       │       │   │       ├── gdbm
│       │       │   │       └── expat
│       │       │   ├── automake
│       │       │   │   └── autoconf
│       │       │   │       ├── m4
│       │       │   │       └── perl
│       │       │   │           ├── berkeley-db
│       │       │   │           │   └── openssl@1.1
│       │       │   │           ├── gdbm
│       │       │   │           └── expat
│       │       │   └── libtool
│       │       │       └── m4
│       │       ├── openssl@1.1
│       │       ├── readline
│       │       │   └── ncurses
│       │       │       ├── pkg-config
│       │       │       └── gpatch
│       │       ├── libffi
│       │       └── zlib
│       ├── gettext
│       │   ├── libxml2
│       │   │   ├── python@3.9
│       │   │   │   ├── pkg-config
│       │   │   │   ├── gdbm
│       │   │   │   ├── mpdecimal
│       │   │   │   ├── openssl@1.1
│       │   │   │   ├── readline
│       │   │   │   │   └── ncurses
│       │   │   │   │       ├── pkg-config
│       │   │   │   │       └── gpatch
│       │   │   │   ├── sqlite
│       │   │   │   │   ├── readline
│       │   │   │   │   │   └── ncurses
│       │   │   │   │   │       ├── pkg-config
│       │   │   │   │   │       └── gpatch
│       │   │   │   │   └── zlib
│       │   │   │   ├── xz
│       │   │   │   ├── bzip2
│       │   │   │   ├── expat
│       │   │   │   ├── libffi
│       │   │   │   ├── ncurses
│       │   │   │   │   ├── pkg-config
│       │   │   │   │   └── gpatch
│       │   │   │   ├── unzip
│       │   │   │   │   └── bzip2
│       │   │   │   └── zlib
│       │   │   ├── readline
│       │   │   │   └── ncurses
│       │   │   │       ├── pkg-config
│       │   │   │       └── gpatch
│       │   │   └── zlib
│       │   └── ncurses
│       │       ├── pkg-config
│       │       └── gpatch
│       ├── ncurses
│       │   ├── pkg-config
│       │   └── gpatch
│       └── zlib
├── openssl@1.1
├── rtmpdump
│   ├── openssl@1.1
│   └── zlib
├── zstd
│   ├── cmake
│   │   ├── ncurses
│   │   │   ├── pkg-config
│   │   │   └── gpatch
│   │   └── openssl@1.1
│   └── zlib
├── krb5
│   ├── openssl@1.1
│   ├── bison
│   │   └── m4
│   └── gettext
│       ├── libxml2
│       │   ├── python@3.9
│       │   │   ├── pkg-config
│       │   │   ├── gdbm
│       │   │   ├── mpdecimal
│       │   │   ├── openssl@1.1
│       │   │   ├── readline
│       │   │   │   └── ncurses
│       │   │   │       ├── pkg-config
│       │   │   │       └── gpatch
│       │   │   ├── sqlite
│       │   │   │   ├── readline
│       │   │   │   │   └── ncurses
│       │   │   │   │       ├── pkg-config
│       │   │   │   │       └── gpatch
│       │   │   │   └── zlib
│       │   │   ├── xz
│       │   │   ├── bzip2
│       │   │   ├── expat
│       │   │   ├── libffi
│       │   │   ├── ncurses
│       │   │   │   ├── pkg-config
│       │   │   │   └── gpatch
│       │   │   ├── unzip
│       │   │   │   └── bzip2
│       │   │   └── zlib
│       │   ├── readline
│       │   │   └── ncurses
│       │   │       ├── pkg-config
│       │   │       └── gpatch
│       │   └── zlib
│       └── ncurses
│           ├── pkg-config
│           └── gpatch
└── zlib

@Rylan12
Copy link
Copy Markdown
Member

Rylan12 commented Oct 3, 2021

The current issue only affects macOS, though, right? Do we need the http mirrors for Linux too?

@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Oct 3, 2021

It's something that we'd ideally have, but won't be a blocker for now.

@Bo98 Bo98 force-pushed the curl-http-mirror branch from 50a58f4 to bd6c0e3 Compare October 4, 2021 01:06
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Would be good to document why e.g. ca-certificates doesn't need this.

@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Oct 4, 2021

Would be good to document why e.g. ca-certificates doesn't need this.

It kinda does except we have not found a HTTP mirror.

Though if we go the --insecure route then that'll be enough for now (only breaking things for those with a really old curl without modern TLS support), which I'll document here.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Though if we go the --insecure route then that'll be enough for now (only breaking things for those with a really old curl without modern TLS support), which I'll document here.

Gotcha 👍🏻

@Bo98 Bo98 force-pushed the curl-http-mirror branch from 7ee642c to f0e4fb9 Compare October 5, 2021 12:27
@Bo98 Bo98 merged commit a18f8b8 into Homebrew:master Oct 5, 2021
@Bo98 Bo98 deleted the curl-http-mirror branch October 5, 2021 12:49
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants