Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to embed the user avatar as the cover art of the audio file #92

Merged
merged 2 commits into from
May 24, 2023
Merged

Add an option to embed the user avatar as the cover art of the audio file #92

merged 2 commits into from
May 24, 2023

Conversation

mikelei8291
Copy link
Contributor

Closes #90.

The option is -e/--embed-cover.
Added a new dependency: mutagen.

Tested on my end with an ended Twitter Space and it worked as expected.

@mikelei8291
Copy link
Contributor Author

Forgot to write documentation for the new method. I added it in a new commit and you may consider doing a squash merge/rebase to avoid the extra commit.

@Ryu1845
Copy link
Collaborator

Ryu1845 commented May 24, 2023

Alright, this seems pretty straightforward. I'll merge for now. I don't know when I'll be able to make a release since I'm pretty busy right now though.

@Ryu1845 Ryu1845 merged commit 0e10366 into HoloArchivists:main May 24, 2023
@mikelei8291
Copy link
Contributor Author

Thanks for merging! I can install from source directly at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add an option to embed the user avatar as the cover art of the audio file
2 participants