Skip to content

Update README.md - #8

Merged
aantn merged 1 commit into
HolmesGPT:masterfrom
saiyam1814:patch-1
Jun 3, 2024
Merged

aantn merged 1 commit into
HolmesGPT:masterfrom
saiyam1814:patch-1

Conversation

@saiyam1814

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Jun 3, 2024 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@aantn aantn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aantn
aantn merged commit e9b480e into HolmesGPT:master Jun 3, 2024
moshemorad added a commit that referenced this pull request May 29, 2025
aantn pushed a commit that referenced this pull request Jun 12, 2026
… eval infra bugs

Run #8 left the arms tied 49/53 with two SDK-only failures and two both-arm
failures. All four root causes identified from Braintrust traces and fixed:

- 236_image_spill_to_disk (SDK-only): the claude CLI caps MCP tool output at
  25k tokens; the eval's report intentionally pads ~100k chars before the
  image attachment, so the cap silently dropped the image. Raise
  MAX_MCP_OUTPUT_TOKENS to 100000 in the engine's CLI env. Verified locally:
  PASS.
- 259_wrong_cluster_logs_confusion (SDK-only, flaky): the agent disclosed the
  cluster mismatch as a property of the data ("index only contains eu-west-2")
  but the eval requires agent-identity framing ("this agent is connected to
  eu-west-2, not us-east-2"). One-line addition to the cluster sentence in the
  system prompt. Verified locally: PASS.
- 19_detect_missing_app_details (both arms failed): the eval (added red in
  #2125) asks Holmes to surface db-certs-authenticator as the close match for
  personal-certs-validator, but no such resource was ever deployed — nothing
  could pass it. Add before_test/after_test creating it as a crashlooping
  deployment in app-19 with a discoverable cause (missing CA bundle) in its
  logs. Verified on a live cluster (SDK engine): PASS.
- 227_count_configmaps_per_namespace (both arms failed): evals 229 and 249
  deployed into namespace app-227 (copy-paste, violating the app-<testid>
  convention), so "namespaces starting with app-227" truthfully totalled 645
  ConfigMaps against the eval's hardcoded 644 — both engines counted the live
  cluster correctly and were marked wrong. Move 229 to app-229 and 249 to
  app-249 (249's own prompt already said app-249). Verified on a live
  cluster: ground truth is 644 again.

Signed-off-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants