Repository navigation
Rename tempo and loki toolset in docs - #787
Conversation
WalkthroughThis update standardizes the naming of Grafana-related toolsets across documentation, configuration, error messages, and tests. Instances of "Grafana Loki" are renamed to "Loki," and "Grafana Tempo" to "Tempo" or "Grafana" where appropriate. Minor documentation and comment updates are included, along with a namespace creation addition in a test fixture. Changes
Sequence Diagram(s)Not applicable: No new features or control flow changes introduced. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
tests/llm/fixtures/test_ask_holmes/23_app_error_in_current_logs/test_case.yaml (1)
6-10: Delete the dedicated namespace inafter_testto avoid residueThe test now creates
app-23, but it is never removed.
Keeping stale namespaces can slow future CI runs and pollute shared clusters.Suggested adjustment:
after_test: | kubectl delete -f ./manifests/ + kubectl delete namespace app-23 || true
🧹 Nitpick comments (2)
tests/llm/fixtures/test_investigate/14_tempo/toolsets.yaml (1)
4-6: YAML boolean style is inconsistent with the rest of the file.
enabled: True(Line 5) uses Python-styleTrue, while every other boolean in the file is lowercase YAML (true/false). Mixing styles can surprise YAML parsers that enforce canonical booleans.- enabled: True + enabled: truedocs/data-sources/builtin-toolsets/grafanaloki.md (1)
1-1: Header rename LGTM, but consider renaming the file for full consistency.
The visible title is now “Loki,” yet the filename (grafanaloki.md) and internal toolset sluggrafana/lokistill carry thegrafanaprefix. If the long-term goal is to drop the prefix everywhere, renaming the file (and updating mkdocs navigation & inbound links) will avoid confusion down the road.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
docs/data-sources/builtin-toolsets/datetime.md(1 hunks)docs/data-sources/builtin-toolsets/grafanaloki.md(1 hunks)docs/data-sources/builtin-toolsets/grafanatempo.md(1 hunks)docs/data-sources/builtin-toolsets/index.md(1 hunks)docs/snippets/toolsets_that_provide_logging.md(1 hunks)holmes/plugins/toolsets/grafana/toolset_grafana_loki.py(1 hunks)mkdocs.yml(1 hunks)tests/llm/fixtures/test_ask_holmes/23_app_error_in_current_logs/test_case.yaml(1 hunks)tests/llm/fixtures/test_investigate/14_tempo/toolsets.yaml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py
📄 CodeRabbit Inference Engine (CLAUDE.md)
**/*.py: ALWAYS place Python imports at the top of the file, not inside functions or methods
Use Ruff for formatting and linting (configured in pyproject.toml)
Type hints required (mypy configuration in pyproject.toml)
Files:
holmes/plugins/toolsets/grafana/toolset_grafana_loki.py
🧠 Learnings (6)
📚 Learning: in robusta-dev/holmesgpt config.example.yaml, the azuremonitorlogs toolset configuration shows "enab...
Learnt from: vishiy
PR: robusta-dev/holmesgpt#782
File: config.example.yaml:31-49
Timestamp: 2025-08-05T00:42:23.792Z
Learning: In robusta-dev/holmesgpt config.example.yaml, the azuremonitorlogs toolset configuration shows "enabled: true" as an example of how to enable the toolset, not as a default setting. The toolset is disabled by default and requires explicit enablement in user configurations.
Applied to files:
tests/llm/fixtures/test_investigate/14_tempo/toolsets.yamldocs/data-sources/builtin-toolsets/grafanatempo.md
📚 Learning: in the kubernetes logs toolset for holmes, both current and previous logs are intentionally fetched ...
Learnt from: nherment
PR: robusta-dev/holmesgpt#408
File: holmes/plugins/toolsets/kubernetes_logs.py:90-97
Timestamp: 2025-05-15T05:13:43.169Z
Learning: In the Kubernetes logs toolset for Holmes, both current and previous logs are intentionally fetched and combined for each pod, even though this requires more API calls. This design ensures all logs are captured even when pods restart but retain their name, providing complete diagnostic information.
Applied to files:
docs/data-sources/builtin-toolsets/grafanaloki.mddocs/data-sources/builtin-toolsets/grafanatempo.mddocs/snippets/toolsets_that_provide_logging.md
📚 Learning: each llm test must use a dedicated namespace app- (e.g., app-01, app-02) to prevent conflict...
Learnt from: CR
PR: robusta-dev/holmesgpt#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-03T07:25:36.018Z
Learning: Each LLM test must use a dedicated namespace app-<testid> (e.g., app-01, app-02) to prevent conflicts when tests run simultaneously
Applied to files:
tests/llm/fixtures/test_ask_holmes/23_app_error_in_current_logs/test_case.yaml
📚 Learning: in llm-as-judge test cases for holmesgpt, expected outputs should be descriptive rather than prescri...
Learnt from: Sheeproid
PR: robusta-dev/holmesgpt#586
File: tests/llm/fixtures/test_ask_holmes/03_what_is_the_command_to_port_forward/test_case.yaml:4-4
Timestamp: 2025-07-02T10:27:17.231Z
Learning: In LLM-as-judge test cases for HolmesGPT, expected outputs should be descriptive rather than prescriptive when testing for flexible responses like port numbers. Using specific values in expected outputs can cause unnecessary test failures when the AI generates different but equally valid responses.
Applied to files:
tests/llm/fixtures/test_ask_holmes/23_app_error_in_current_logs/test_case.yaml
📚 Learning: never use resource names that hint at the problem or expected behavior (e.g., avoid broken-pod, test...
Learnt from: CR
PR: robusta-dev/holmesgpt#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-03T07:25:36.018Z
Learning: Never use resource names that hint at the problem or expected behavior (e.g., avoid broken-pod, test-project-that-does-not-exist, crashloop-app). Use neutral names that don't give away what the LLM should discover
Applied to files:
tests/llm/fixtures/test_ask_holmes/23_app_error_in_current_logs/test_case.yaml
📚 Learning: all pod names must be unique across tests (e.g., giant-narwhal, blue-whale, sea-turtle) - never reus...
Learnt from: CR
PR: robusta-dev/holmesgpt#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-03T07:25:36.018Z
Learning: All pod names must be unique across tests (e.g., giant-narwhal, blue-whale, sea-turtle) - never reuse pod names between tests
Applied to files:
tests/llm/fixtures/test_ask_holmes/23_app_error_in_current_logs/test_case.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Pre-commit checks
- GitHub Check: llm_evals
- GitHub Check: Pre-commit checks
🔇 Additional comments (6)
tests/llm/fixtures/test_investigate/14_tempo/toolsets.yaml (1)
22-22: Comment wording now consistent – looks good.
The updated comment removes the “Grafana” prefix, matching the new naming convention.docs/snippets/toolsets_that_provide_logging.md (1)
8-8: Bullet text updated correctly.
The list now shows “Loki,” matching the broader rename.docs/data-sources/builtin-toolsets/datetime.md (1)
9-9: Dependency list updated – looks good.
No further action needed.mkdocs.yml (1)
168-169: Confirm page titles inside linked docs also reflect the new wordingNav labels were shortened to “Loki” / “Tempo”, but the underlying markdown files are still named
grafanaloki.mdandgrafanatempo.md.
Please make sure the H1 headings inside those two files were also updated, otherwise the page titles shown in the browser tab / search results will still read Grafana Loki and Grafana Tempo, undermining the consistency this PR aims for.
If not yet done, a one-liner fix in each markdown file is enough.docs/data-sources/builtin-toolsets/index.md (1)
20-21: LGTM – label change onlyDisplay names updated to match the new terminology; links remain intact. No further action needed.
holmes/plugins/toolsets/grafana/toolset_grafana_loki.py (1)
50-53: LGTM – message text aligns with new namingOnly the error message changed; logic remains untouched and consistent with the overall rebranding.
Co-authored-by: moshemorad <moshemorad12340@gmail.com>
2 participants
To reflect that they can be used without grafana