Fix logs toolsets prompts - #767
Merged
moshemorad merged 1 commit intoJul 31, 2025
Merged
moshemorad merged 1 commit into
moshemorad merged 1 commit into
Conversation
Contributor
WalkthroughThis change adds descriptive header comments and brief explanations for the Coralogix and Datadog log toolsets in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
aantn
approved these changes
Jul 31, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
holmes/plugins/prompts/_fetch_logs.jinja2 (2)
20-22: Align heading style with the rest of the prompt for uniformityExisting sections (e.g. the Loki branch) either use a leading comment (
# Logs) or a bullet list, while this branch introduces second-level Markdown headings (## …). Consider converting these lines to match the prevailing style (bullet list or a single#header) or introduce the same heading pattern in the other branches for consistency.-## Coralogix Logs Toolset -Tools to search and fetch logs from Coralogix. +* Coralogix Logs Toolset + Tools to search and fetch logs from Coralogix.
26-28: Maintain stylistic consistency across toolset branchesSame observation as above: using
##headings only here and in the Coralogix branch makes the prompt formatting uneven when rendered. Harmonising the formatting keeps the generated prompt predictable.-## Datadog Logs Toolset -Tools to search and fetch logs from Datadog. +* Datadog Logs Toolset + Tools to search and fetch logs from Datadog.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
holmes/plugins/prompts/_fetch_logs.jinja2(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
holmes/plugins/prompts/**/*.jinja2
📄 CodeRabbit Inference Engine (CLAUDE.md)
Prompts: holmes/plugins/prompts/{name}.jinja2
Files:
holmes/plugins/prompts/_fetch_logs.jinja2
🧠 Learnings (4)
📚 Learning: applies to holmes/plugins/prompts/**/*.jinja2 : prompts: holmes/plugins/prompts/{name}.jinja2...
Learnt from: CR
PR: robusta-dev/holmesgpt#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-27T14:10:31.590Z
Learning: Applies to holmes/plugins/prompts/**/*.jinja2 : Prompts: holmes/plugins/prompts/{name}.jinja2
Applied to files:
holmes/plugins/prompts/_fetch_logs.jinja2
📚 Learning: applies to holmes/plugins/toolsets/**/*.yaml : toolsets: holmes/plugins/toolsets/{name}.yaml or {nam...
Learnt from: CR
PR: robusta-dev/holmesgpt#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-27T14:10:31.590Z
Learning: Applies to holmes/plugins/toolsets/**/*.yaml : Toolsets: holmes/plugins/toolsets/{name}.yaml or {name}/
Applied to files:
holmes/plugins/prompts/_fetch_logs.jinja2
📚 Learning: in the kubernetes logs toolset for holmes, both current and previous logs are intentionally fetched ...
Learnt from: nherment
PR: robusta-dev/holmesgpt#408
File: holmes/plugins/toolsets/kubernetes_logs.py:90-97
Timestamp: 2025-05-15T05:13:43.169Z
Learning: In the Kubernetes logs toolset for Holmes, both current and previous logs are intentionally fetched and combined for each pod, even though this requires more API calls. This design ensures all logs are captured even when pods restart but retain their name, providing complete diagnostic information.
Applied to files:
holmes/plugins/prompts/_fetch_logs.jinja2
📚 Learning: the `fetch_logs` method in kuberneteslogstoolset is designed to apply the limit parameter after filt...
Learnt from: nherment
PR: robusta-dev/holmesgpt#408
File: holmes/plugins/toolsets/kubernetes_logs.py:100-102
Timestamp: 2025-05-15T05:14:06.519Z
Learning: The `fetch_logs` method in KubernetesLogsToolset is designed to apply the limit parameter after filtering and combining both current and previous logs, rather than using the API's tail_lines parameter, to ensure the limit applies to the final combined log set.
Applied to files:
holmes/plugins/prompts/_fetch_logs.jinja2
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Pre-commit checks
- GitHub Check: llm_evals
Contributor
moshemorad
deleted the
ROB-1868-fix-issue-when-user-asks-for-logs-holmes-isnt-fetching-logs-but-spans
branch
July 31, 2025 16:06
This was referenced Aug 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.