Skip to content

minor improvements to user-facing tool descriptions #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aantn merged 2 commits into from
Jul 1, 2025
Merged

minor improvements to user-facing tool descriptions #582

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30fc5fc
minor improvements to user-facing tool descriptions
aantn Jun 30, 2025
5a8cba8
Merge branch 'master' into more-consistent-tool-descriptions
aantn Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions holmes/plugins/toolsets/prometheus/prometheus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ def _invoke(self, params: Any) -> StructuredToolResult:
)

def get_parameterized_one_liner(self, params) -> str:
return f'list available prometheus metrics: name_filter="{params.get("name_filter", "<no filter>")}", type_filter="{params.get("type_filter", "<no filter>")}"'
return f'Search Available Prometheus Metrics: name_filter="{params.get("name_filter", "<no filter>")}", type_filter="{params.get("type_filter", "<no filter>")}"'


class ExecuteInstantQuery(BasePrometheusTool):
Expand Down Expand Up @@ -567,7 +567,7 @@ def _invoke(self, params: Any) -> StructuredToolResult:
def get_parameterized_one_liner(self, params) -> str:
query = params.get("query")
description = params.get("description")
return f"Prometheus query. query={query}, description={description}"
return f"Execute Prometheus Query (instant): promql='{query}', description='{description}'"


class ExecuteRangeQuery(BasePrometheusTool):
Expand Down Expand Up @@ -716,7 +716,7 @@ def get_parameterized_one_liner(self, params) -> str:
end = params.get("end")
step = params.get("step")
description = params.get("description")
return f"Prometheus query_range. query={query}, start={start}, end={end}, step={step}, description={description}"
return f"Execute Prometheus Query (range): promql='{query}', start={start}, end={end}, step={step}, description='{description}'"


class PrometheusToolset(Toolset):
Expand Down
6 changes: 3 additions & 3 deletions holmes/plugins/toolsets/robusta/robusta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def _invoke(self, params: Dict) -> StructuredToolResult:
)

def get_parameterized_one_liner(self, params: Dict) -> str:
return "Fetch metadata and history"
return "Fetch Alert Metadata"


class FetchResourceRecommendation(Tool):
Expand Down Expand Up @@ -138,7 +138,7 @@ def _invoke(self, params: Dict) -> StructuredToolResult:
)

def get_parameterized_one_liner(self, params: Dict) -> str:
return f"Fetch resource recommendation ({str(params)})"
return f"Check Historical Resource Utilization: ({str(params)})"


class FetchConfigurationChanges(Tool):
Expand Down Expand Up @@ -196,7 +196,7 @@ def _invoke(self, params: Dict) -> StructuredToolResult:
)

def get_parameterized_one_liner(self, params: Dict) -> str:
return f"Fetch change history ({str(params)})"
return f"Search Change History: ({str(params)})"


class RobustaToolset(Toolset):
Expand Down