prometheus: fix reading prometheus options by vrutkovs · Pull Request #558 · HolmesGPT/holmesgpt

vrutkovs · 2025-06-23T12:20:24Z

self.toolset.config is a dict, not an object, so we need to access its items using the get method instead of attribute access.

Not sure if this is intended though, perhaps config is meant to be an object?

CLAassistant · 2025-06-23T12:20:31Z

All committers have signed the CLA.

coderabbitai · 2025-06-23T12:20:37Z

Walkthrough

The update refactors configuration property access in several classes by replacing direct attribute access with dictionary-style .get() calls. This adjustment is applied to configuration retrievals within methods handling Prometheus-related operations, ensuring safer access without changing logic, error handling, or control flow.

Changes

File(s)	Change Summary
holmes/plugins/toolsets/prometheus/prometheus.py	Replaced direct attribute access of config properties with `.get()` calls in multiple methods.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Plugin
    participant Config

    User->>Plugin: Invoke Prometheus-related method
    Plugin->>Config: Retrieve configuration with .get('key')
    Config-->>Plugin: Return value or None
    Plugin->>Plugin: Proceed with logic (caching, API calls, etc.)
    Plugin-->>User: Return result or error

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between abdfd7f9a8c4bc782032d4bde00d456148647378 and a598578.

📒 Files selected for processing (1)

holmes/plugins/toolsets/prometheus/prometheus.py (11 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

holmes/plugins/toolsets/prometheus/prometheus.py

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: build (3.12)
GitHub Check: build (3.11)
GitHub Check: build (3.10)
GitHub Check: build (3.12)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

`self.toolset.config` is a dict, not an object, so we need to access its items using the `get` method instead of attribute access.

arikalon1 · 2025-06-23T14:46:30Z

hey @vrutkovs

Thanks for the PR
I think the config object in the prometheus toolset, should be a PrometheusConfig object, and not a dict
The fact that it's a dict, is due to another bug, which should be fixed, but was not merged yet

That bug fix should be merged within a few days - I'll update you when it does, and, if that's ok, will ask you to check if this fix is still required

vrutkovs · 2025-06-23T14:50:34Z

Oh, okay, thanks! I'll keep the PR open for now (in case I find some other fixes along the way too)

mainred · 2025-06-24T00:26:19Z


    def _invoke(self, params: Any) -> StructuredToolResult:
-        if not self.toolset.config or not self.toolset.config.prometheus_url:
+        if not self.toolset.config or not self.toolset.config.get("prometheus_url"):


Hey @vrutkovs I think we want to fix the config issue by #535. The config object should be initialized during check-prerequisite, but was skipped for status check.

Thanks, that fixed it for me!

prometheus: fix reading prometheus options

a598578

`self.toolset.config` is a dict, not an object, so we need to access its items using the `get` method instead of attribute access.

vrutkovs force-pushed the prom-fix branch from abdfd7f to a598578 Compare June 23, 2025 12:28

mainred reviewed Jun 24, 2025

View reviewed changes

vrutkovs closed this Jun 24, 2025

Navigation Menu

prometheus: fix reading prometheus options - #558

prometheus: fix reading prometheus options#558
vrutkovs wants to merge 1 commit into
HolmesGPT:masterfrom
vrutkovs:prom-fix

vrutkovs commented Jun 23, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Jun 23, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 23, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

arikalon1 commented Jun 23, 2025

Uh oh!

vrutkovs commented Jun 23, 2025

Uh oh!

mainred Jun 24, 2025

Uh oh!

vrutkovs Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vrutkovs commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

arikalon1 commented Jun 23, 2025

Uh oh!

vrutkovs commented Jun 23, 2025

Uh oh!

mainred Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

vrutkovs Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vrutkovs commented Jun 23, 2025 •

edited

Loading

CLAassistant commented Jun 23, 2025 •

edited

Loading

coderabbitai Bot commented Jun 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)