Adding toolsets for Azure Network Security Groups (NSGs) - #538
Conversation
Adding toolsets to get all NSGs and NSG rules for a subscription. Also fixing some descriptions to ensure Holmes calls the right AKS get cluster tool.
WalkthroughThe AKS toolset configuration was updated by renaming a tool, removing a cluster listing tool, clarifying another tool's description, and adding two new tools for managing Network Security Groups (NSGs) using Azure CLI commands. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AKS Toolset
User->>AKS Toolset: aks_get_cluster (Get AKS cluster config)
User->>AKS Toolset: aks_list_clusters_by_rg (List clusters in resource group)
User->>AKS Toolset: get_all_nsgs (List all NSGs)
User->>AKS Toolset: get_nsg_rules (List NSG rules for specific NSG)
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
holmes/plugins/toolsets/aks.yaml (3)
67-71: Include explicit subscription flag in get_all_nsgs
For consistency with other tools, consider appending--subscription {{ SUBSCRIPTION_ID }}to theaz network nsg listcommand so it targets the intended subscription explicitly.
72-76: Fix typo in get_nsg_rules description
Correct"Gets alls NSG rules associated with a specific NSG"to"Gets all NSG rules associated with a specific NSG"to fix the typo and maintain consistent grammar.
76-76: Add newline at end of file
YAML files should end with a newline character to satisfy linting rules.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
holmes/plugins/toolsets/aks.yaml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
holmes/plugins/toolsets/aks.yaml
[error] 76-76: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (2)
holmes/plugins/toolsets/aks.yaml (2)
16-17: Ensure references updated after renaming aks_get_cluster
Ensure that all references (scripts, docs, integrations) to the oldaks_show_clustertool are updated toaks_get_clusterto prevent broken invocations.
22-22: Clarify usage note for aks_list_clusters_by_rg
The expanded description clearly distinguishes this tool’s purpose when listing clusters by resource group. This improves discoverability and reduces misuse.
Minor fixes based on code review.
|
|
|
@julia-yin Thanks for your change. It looks good. I will merge your PR. |
3 participants
Changes: