Repository navigation
ci: stop running evals automatically on every commit - #2218
Conversation
Evals were running on every PR commit (eval-regression.yaml on pull_request synchronize) and every push to master (eval-master.yaml), which was the main CI eval cost driver even when no one looked at the results. Switch both to on-demand: - eval-regression.yaml: trigger only on the `labeled` pull_request event instead of opened/synchronize/reopened/labeled, and skip by default in the automatic path unless the PR carries an evals-* label (evals-tag-*, evals-id-*, evals-model-*). /eval comments and workflow_dispatch are unaffected, so on-demand runs still work. - eval-master.yaml: drop the push-to-master trigger; refresh the baseline on demand via workflow_dispatch. The weekly benchmark cron (eval-benchmarks.yaml) is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BzLq3Ubqo1TTonzkUASL3X Signed-off-by: Claude <noreply@anthropic.com>
WalkthroughThe master baseline eval workflow removes its automatic ChangesEval Workflow Opt-in Triggering
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Docker images ready for
Use these tags to pull the images for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:aa58252b6
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:aa58252b6 me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:aa58252b6
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:aa58252b6
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes-operator:aa58252b6
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes-operator:aa58252b6 me-west1-docker.pkg.dev/robusta-development/development/holmes-operator-dev:aa58252b6
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-operator-dev:aa58252b6Patch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:aa58252b6 \
--set operator.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set operator.image=holmes-operator-dev:aa58252b6Robusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:aa58252b6 \
--set holmes.operator.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.operator.image=holmes-operator-dev:aa58252b6 |
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/eval-regression.yaml:
- Around line 7-9: The current workflow triggers on any label being added to a
PR due to the `types: [labeled]` configuration. To prevent unnecessary CI runs
when unrelated labels are added to PRs that already have `evals-*` labels, add a
conditional check that verifies the specific label being added matches the
evaluation label pattern. Use the GitHub Actions `if` condition to check
`github.event.label.name` against the relevant `evals-*` label names, so the
workflow only triggers when the appropriate evaluation label is specifically
added, not on any arbitrary label addition.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bd7e0c36-0349-4980-b097-e424df309bcb
📒 Files selected for processing (2)
.github/workflows/eval-master.yaml.github/workflows/eval-regression.yaml
Evals were running on every PR commit (eval-regression.yaml on
pull_request synchronize) and every push to master (eval-master.yaml),
which was the main CI eval cost driver even when no one looked at the
results. Switch both to on-demand:
labeledpull_request eventinstead of opened/synchronize/reopened/labeled, and skip by default in
the automatic path unless the PR carries an evals-* label
(evals-tag-, evals-id-, evals-model-*). /eval comments and
workflow_dispatch are unaffected, so on-demand runs still work.
on demand via workflow_dispatch.
The weekly benchmark cron (eval-benchmarks.yaml) is unchanged.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01BzLq3Ubqo1TTonzkUASL3X
Signed-off-by: Claude noreply@anthropic.com
Summary by CodeRabbit