Load config from env override - #2099
naomi-robusta wants to merge 2 commits into
Conversation
When the LLM requested a tool call requiring approval and the user abandoned it (closed the approval modal or asked a new follow-up question without deciding), the conversation history ended up with an assistant tool_calls message that had no matching tool result. The next LLM call then failed with "tool_use ids were found without tool_result blocks immediately after" on Anthropic/Bedrock. call_stream now resolves any orphaned tool calls by injecting a denial tool result, so the conversation can continue with the user's new request. https://claude.ai/code/session_012djRRHcKAG9NTsYZoQiGVj Signed-off-by: Claude <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe PR adds orphaned assistant tool call resolution to ChangesOrphaned Tool Call Resolution
Configuration Loading
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Results of HolmesGPT evalsAutomatically triggered by commit 570b236 on branch Results of HolmesGPT evals
Benchmark Comparison DetailsMaster baseline: latest master-* experiment (post-merge regression eval)
Benchmark baseline: latest ci-benchmark experiment on master
Time comparison (seconds):
Cost comparison:
Total tokens comparison:
Cached tokens comparison:
Turns comparison:
Tool calls comparison:
Comparison indicators:
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line): Run evals on a different branch (e.g., master) for comparison:
Quick re-run: Use Option 2: Trigger via GitHub Actions UI → "Run workflow" Option 3: Add PR labels to include extra evals (applies to both automatic runs and
Examples: 🏷️ Valid tags
🤖 Valid models
Commands: CLI: |
|
✅ Docker images ready for
Use these tags to pull the images for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:1ef054da
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:1ef054da me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:1ef054da
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:1ef054da
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes-operator:1ef054da
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes-operator:1ef054da me-west1-docker.pkg.dev/robusta-development/development/holmes-operator-dev:1ef054da
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-operator-dev:1ef054daPatch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:1ef054da \
--set operator.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set operator.image=holmes-operator-dev:1ef054daRobusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:1ef054da \
--set holmes.operator.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.operator.image=holmes-operator-dev:1ef054da |
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 participants
Summary by CodeRabbit
Bug Fixes
LOAD_CONFIG_FROM_ENVenvironment variable flag.Tests