ROB-3773 bump github app mcp and build for arm/amd - #1986
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
📂 Previous Runs📜 #1 · Run @ __2504295__ (#25273099199) — May 3, 07:34 UTC✅ Results of HolmesGPT evalsAutomatically triggered by commit 2504295 on branch Results of HolmesGPT evals
Benchmark Comparison DetailsBaseline: latest ci-benchmark experiment on master Status: Success - 73 test/model combinations loaded Benchmark experiment:
No benchmark data available for comparison. Benchmark has no cost, total tokens, cached tokens data. Will appear after the next weekly benchmark run. Comparison indicators:
✅ Results of HolmesGPT evalsAutomatically triggered by commit 0998fdf on branch Results of HolmesGPT evals
Benchmark Comparison DetailsBaseline: latest ci-benchmark experiment on master Status: Success - 73 test/model combinations loaded Benchmark experiment:
No benchmark data available for comparison. Benchmark has no cost, total tokens, cached tokens data. Will appear after the next weekly benchmark run. Comparison indicators:
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line): Run evals on a different branch (e.g., master) for comparison:
Quick re-run: Use Option 2: Trigger via GitHub Actions UI → "Run workflow" Option 3: Add PR labels to include extra evals (applies to both automatic runs and
Examples: 🏷️ Valid tags
🤖 Valid models
Commands: CLI: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughGitHub MCP addon image version updated in Helm values: ChangesHelm Values Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 10 minutes and 10 seconds.Comment |
|
✅ Docker images ready for
Use these tags to pull the images for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:f9cf8a5d
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:f9cf8a5d me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:f9cf8a5d
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:f9cf8a5d
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes-operator:f9cf8a5d
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes-operator:f9cf8a5d me-west1-docker.pkg.dev/robusta-development/development/holmes-operator-dev:f9cf8a5d
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-operator-dev:f9cf8a5dPatch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:f9cf8a5d \
--set operator.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set operator.image=holmes-operator-dev:f9cf8a5dRobusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:f9cf8a5d \
--set holmes.operator.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.operator.image=holmes-operator-dev:f9cf8a5d |
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
helm/holmes/values.yaml (1)
552-556: 💤 Low valueConsider block scalar (
>-) instead of backslash-newline continuation for readability.When you end a line with
\, YAML treats the next line as a continuation of the same string — no space, no newline. The values parse correctly, but putting\at the end of a line to escape the newline is valid in double-quoted strings, though the block scalar syntax is usually a nicer approach for wrapping long strings.Block scalars with
>-(folded, strip trailing newline) are the conventional Helm pattern for long single-line config values:♻️ Suggested alternative using folded block scalars
- allowedCommands: "edit,patch,delete,scale,rollout,cordon,uncordon,drain,taint,l\ - abel,annotate" + allowedCommands: >- + edit,patch,delete,scale,rollout,cordon,uncordon,drain,taint,label,annotate # Comma-separated list of blocked flags - dangerousFlags: "--kubeconfig,--context,--cluster,--user,--token,--as,--as-grou\ - p,--as-uid" + dangerousFlags: >- + --kubeconfig,--context,--cluster,--user,--token,--as,--as-group,--as-uidThe same applies to
enabledToolsat line 613:- enabledTools: "confluence_search,confluence_get_page,confluence_get_page_conten\ - t,confluence_get_comments" + enabledTools: >- + confluence_search,confluence_get_page,confluence_get_page_content,confluence_get_comments🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@helm/holmes/values.yaml` around lines 552 - 556, The YAML uses backslash-newline continuation inside double-quoted strings for long values (see allowedCommands and dangerousFlags, also enabledTools) which is harder to read and error-prone; replace those quoted, backslash-continued strings with folded block scalars (e.g., use >- to fold into a single-line string) for each value so the long comma-separated lists remain single-line when parsed but are readable in the file — update the allowedCommands, dangerousFlags (and enabledTools) entries to use folded block scalars instead of backslash escapes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@helm/holmes/values.yaml`:
- Around line 552-556: The YAML uses backslash-newline continuation inside
double-quoted strings for long values (see allowedCommands and dangerousFlags,
also enabledTools) which is harder to read and error-prone; replace those
quoted, backslash-continued strings with folded block scalars (e.g., use >- to
fold into a single-line string) for each value so the long comma-separated lists
remain single-line when parsed but are readable in the file — update the
allowedCommands, dangerousFlags (and enabledTools) entries to use folded block
scalars instead of backslash escapes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1c863e5e-6b3b-4ea5-90be-ba6912b25b20
📒 Files selected for processing (1)
helm/holmes/values.yaml
This reverts commit 2504295.
2 participants
Summary by CodeRabbit