Repository navigation
Refactor Kubernetes toolsets documentation and consolidate permissions - #1893
Merged
Merged
Conversation
The "Core ✓" and "Logs ✓" headers rendered as odd emoji in the docs. The "Enabled by Default" admonition already conveys this information. https://claude.ai/code/session_01Ep5yCqMFDyqCCjKPoVYFAY Signed-off-by: Claude <noreply@anthropic.com>
…t permissions - Update Core capabilities: replace 10 outdated tools with actual 3 (kubernetes_jq_query, kubernetes_tabular_query, kubernetes_count) - Add missing kubectl_container_previous_logs to Logs capabilities - Fix toolset names to match code (kube-prometheus-stack, krew-extras, kube-lineage-extras) - Fix Prometheus Stack capabilities: 1 tool not 3 - Add "Not Enabled by Default" admonitions to Live Metrics, Kube Prometheus Stack, and Resource Lineage sections - Add note distinguishing kube-prometheus-stack from standalone Prometheus toolset - Move "Adding Permissions" section to its own page (kubernetes-permissions.md) to declutter the toolsets ToC https://claude.ai/code/session_01Ep5yCqMFDyqCCjKPoVYFAY Signed-off-by: Claude <noreply@anthropic.com>
Use Option B structure: toolsets live under "## Toolsets" as ### subsections, and "## Adding Permissions" is a peer heading clearly separate in the ToC. Also demote "Configuration" and "Capabilities" sub-headers to bold text since they're inside ### sections now (avoids deep nesting). Removes the separate kubernetes-permissions.md page from previous commit in favor of keeping everything on one page. https://claude.ai/code/session_01Ep5yCqMFDyqCCjKPoVYFAY Signed-off-by: Claude <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
WalkthroughDocumentation reorganization of the Kubernetes toolsets guide, including restructuring sections under a unified "Toolsets" header, updating tool identifiers and capabilities descriptions, and adding explicit "Not Enabled by Default" notes for Live Metrics and resource lineage toolsets. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/data-sources/builtin-toolsets/kubernetes.md`:
- Around line 76-81: Remove the entire "Capabilities:" section including the
heading "Capabilities:" and the markdown table rows referencing kubectl_top_pods
and kubectl_top_nodes; locate the block containing the table and delete it so
the document no longer lists toolset capabilities (remove the "Capabilities:"
heading plus the pipe-table that lists kubectl_top_pods and kubectl_top_nodes).
- Around line 105-129: Remove the "Capabilities" markdown table in the Resource
Lineage section that lists kubectl_lineage_children and kubectl_lineage_parents;
specifically delete the table block (the header row, separator, and the two rows
naming the tools) so the section only includes the note, description, and
configuration examples (i.e., remove references to the symbols
kubectl_lineage_children and kubectl_lineage_parents from
docs/data-sources/builtin-toolsets/kubernetes.md).
- Around line 83-103: Remove the entire "Capabilities" section and its Markdown
table under the "Kube Prometheus Stack" heading in kubernetes.md (the block
starting with "**Capabilities:**" and the table rows including
"get_prometheus_target"), leaving the rest of the toolset description and
configuration example intact.
- Around line 47-58: Remove the entire "Capabilities:" section from the
Kubernetes builtin toolset doc (the header "Capabilities:" and the markdown
table listing kubectl_logs, kubectl_logs_all_containers, kubectl_previous_logs,
kubectl_previous_logs_all_containers, kubectl_container_previous_logs,
kubectl_container_logs, kubectl_logs_grep, kubectl_logs_all_containers_grep);
leave any surrounding descriptive content intact and ensure no broken markdown
remains after deleting that header and table.
- Around line 21-27: Remove the "Capabilities:" section and its table (the
header and the rows listing kubernetes_jq_query, kubernetes_tabular_query,
kubernetes_count) from the markdown so the doc no longer enumerates tool
capabilities; simply delete that block and ensure surrounding content remains
valid markdown (no leftover orphaned blank lines or table separators) in
kubernetes.md.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 31e541e7-2a6d-4e05-b85e-8c4dc0b56f3d
📒 Files selected for processing (1)
docs/data-sources/builtin-toolsets/kubernetes.md
aantn
enabled auto-merge (squash)
April 12, 2026 11:14
Sheeproid
approved these changes
Apr 12, 2026
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restructures the Kubernetes toolsets documentation to better organize content and improve clarity. The main changes include consolidating permissions documentation into a dedicated page, updating toolset descriptions, and clarifying which toolsets are enabled by default.
Key Changes
kubernetes_jq_query- Query resources with jq filters and paginationkubernetes_tabular_query- Extract fields in tabular format with filteringkubernetes_count- Count resources matching jq filterskubectl_container_previous_logstoolkubernetes-permissions.mdfile for better organizationkube-prometheus-stack,kube-lineage-extras,krew-extras).nav.ymlNotable Implementation Details
https://claude.ai/code/session_01Ep5yCqMFDyqCCjKPoVYFAY
Summary by CodeRabbit