Repository navigation
Document tool approval behavior and update API reference - #1800
Merged
Merged
Conversation
…val is false Clarify that when enable_tool_approval is false (the default for server/automation), tools requiring approval are converted to errors and fed back to the LLM for self-correction, rather than silently failing. https://claude.ai/code/session_01FKBNNFQXTFdQDFqGm4GXQp Signed-off-by: Claude <noreply@anthropic.com>
Contributor
Claude Code ReviewThis repository is configured for manual code reviews. Comment |
aantn
enabled auto-merge (squash)
March 17, 2026 00:19
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR updates the HTTP API documentation to add a "Tool Approval Behavior" section describing how the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
arikalon1
approved these changes
Mar 17, 2026
henrikrexed
pushed a commit
to henrikrexed/holmesgpt
that referenced
this pull request
Mar 17, 2026
) ## Summary This PR enhances the HTTP API documentation by clarifying the `enable_tool_approval` parameter behavior and adding a dedicated section explaining how tool approval works in different contexts. ## Changes - Updated the `enable_tool_approval` parameter description in the API reference table to reference a new detailed behavior section - Added new "Tool Approval Behavior" section that documents: - How `enable_tool_approval: true` works for interactive clients (pauses stream, emits `approval_required` event, requires follow-up request with `tool_decisions`) - How `enable_tool_approval: false` works for server/automation contexts (automatically converts unapproved tools to errors, allows LLM self-correction) - Use case clarification that server-mode integrations don't require human-in-the-loop approval ## Details The documentation now provides clear guidance on when and how to use the tool approval feature, helping users understand the different behaviors for interactive vs. automated scenarios. This is particularly useful for integrations like Keep workflows that operate in server mode without human intervention. https://claude.ai/code/session_01FKBNNFQXTFdQDFqGm4GXQp Signed-off-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the HTTP API documentation by clarifying the
enable_tool_approvalparameter behavior and adding a dedicated section explaining how tool approval works in different contexts.Changes
enable_tool_approvalparameter description in the API reference table to reference a new detailed behavior sectionenable_tool_approval: trueworks for interactive clients (pauses stream, emitsapproval_requiredevent, requires follow-up request withtool_decisions)enable_tool_approval: falseworks for server/automation contexts (automatically converts unapproved tools to errors, allows LLM self-correction)Details
The documentation now provides clear guidance on when and how to use the tool approval feature, helping users understand the different behaviors for interactive vs. automated scenarios. This is particularly useful for integrations like Keep workflows that operate in server mode without human intervention.
https://claude.ai/code/session_01FKBNNFQXTFdQDFqGm4GXQp
Summary by CodeRabbit