Remove path filters from build-and-test workflow by aantn · Pull Request #1633 · HolmesGPT/holmesgpt

aantn · 2026-02-24T07:56:01Z

Summary

Simplified the pull request trigger configuration for the build-and-test workflow by removing path-based filtering logic.

Changes

Removed the paths filter from the pull_request trigger that was excluding documentation files (docs/**, **/*.md, mkdocs.yml) with an exception for docs/reference/http-api.md
The workflow will now run on all pull requests without path-based conditions

Rationale

This change ensures the build and test workflow runs consistently on all pull requests, eliminating the complexity of maintaining path exclusion rules. This provides more reliable CI/CD execution and prevents edge cases where relevant changes might be skipped due to path filtering logic.

https://claude.ai/code/session_014U4VUp67Ww8B1bdJgf2Rpw

Summary by CodeRabbit

Chores
- Modified CI/CD workflow configuration to run on all pull requests instead of only when specific files change.

… docs PRs The workflow had a paths filter that excluded docs/** and **/*.md, which prevented the entire workflow from running on docs-only PRs. This meant the build-and-test-gate job (required by branch protection) never reported a status, leaving PRs stuck at "Waiting for status to be reported." The job-level check-changes logic already handles docs-only detection and correctly skips tests while still reporting a green gate status. The workflow-level path filter was redundant and broke this gate pattern. https://claude.ai/code/session_014U4VUp67Ww8B1bdJgf2Rpw Signed-off-by: Claude <noreply@anthropic.com>

github-actions · 2026-02-24T07:56:16Z

✅ Results of HolmesGPT evals

Automatically triggered by commit 102c2a8 on branch claude/fix-build-gate-docs-Hhqw9

View workflow logs

Results of HolmesGPT evals

ask_holmes: 9/9 test cases were successful, 0 regressions

Status	Test case	Time	Turns	Tools	Cost
✅	09_crashpod	36.0s	5	11	$0.2483
✅	101_loki_historical_logs_pod_deleted	45.4s	6	11	$0.2652
✅	111_pod_names_contain_service	40.0s	6	14	$0.2776
✅	112_find_pvcs_by_uuid	26.1s	4	5	$0.2006
✅	12_job_crashing	33.4s	5	11	$0.2379
✅	176_network_policy_blocking_traffic_no_runbooks	48.5s	7	16	$0.2995
✅	24_misconfigured_pvc	36.5s	5	13	$0.2431
✅	43_current_datetime_from_prompt	6.2s	1	—	$0.1128
✅	61_exact_match_counting	17.8s	4	4	$0.1684
	Total	32.2s avg	4.8 avg	10.6 avg	$2.0534

📖 Legend

Icon	Meaning
✅	The test was successful
➖	The test was skipped
⚠️	The test failed but is known to be flaky or known to fail
🚧	The test had a setup failure (not a code regression)
🔧	The test failed due to mock data issues (not a code regression)
🚫	The test was throttled by API rate limits/overload
❌	The test failed and should be fixed before merging the PR

🔄 Re-run evals manually

⚠️ Warning: /eval comments always run using the workflow from master, not from this PR branch. If you modified the GitHub Action (e.g., added secrets or env vars), those changes won't take effect.

To test workflow changes, use the GitHub CLI or Actions UI instead:
gh workflow run eval-regression.yaml --repo HolmesGPT/holmesgpt --ref claude/fix-build-gate-docs-Hhqw9 -f markers=regression -f filter=

Option 1: Comment on this PR with /eval:

/eval
tags: regression

Or with more options (one per line):

/eval
model: gpt-4o
tags: regression
filter: 09_crashpod
iterations: 5

Run evals on a different branch (e.g., master) for comparison:

/eval
branch: master
tags: regression

Option	Description
`model`	Model(s) to test (default: same as automatic runs)
`tags`	Pytest tags / markers (no default - runs all tests!)
`filter`	Pytest -k filter (use `/list` to see valid eval names)
`iterations`	Number of runs, max 10
`branch`	Run evals on a different branch (for cross-branch comparison)

Quick re-run: Use /rerun to re-run the most recent /eval on this PR with the same parameters.

Option 2: Trigger via GitHub Actions UI → "Run workflow"

Option 3: Add PR labels to include extra evals in automatic regression runs:

Label	Effect
`evals-tag-<name>`	Run tests with tag `<name>` alongside regression
`evals-id-<name>`	Run a specific eval by test ID

Examples: evals-tag-easy, evals-id-09_crashpod

🏷️ Valid tags

benchmark, chain-of-causation, compaction, confluence, context_window, coralogix, counting, database, datadog, datetime, db-connectors, easy, elasticsearch, embeds, fast, frontend, grafana-dashboard, hard, integration, kafka, kubernetes, leaked-information, logs, loki, medium, metrics, network, newrelic, no-cicd, numerical, one-test, port-forward, prometheus, question-answer, regression, runbooks, slackbot, storage, toolset-limitation, traces, transparency

Commands: /eval · /rerun · /list

CLI: gh workflow run eval-regression.yaml --repo HolmesGPT/holmesgpt --ref claude/fix-build-gate-docs-Hhqw9 -f markers=regression -f filter=

github-actions · 2026-02-24T07:56:20Z

✅ Docker images ready for 80e8e7ef (built in 7m 37s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use these tags to pull the images for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:80e8e7ef
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:80e8e7ef me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:80e8e7ef
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:80e8e7ef
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes-operator:80e8e7ef
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes-operator:80e8e7ef me-west1-docker.pkg.dev/robusta-development/development/holmes-operator-dev:80e8e7ef
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-operator-dev:80e8e7ef

Patch Helm values in one line (choose the chart you use):

HolmesGPT chart:

helm upgrade --install holmesgpt ./helm/holmes \
  --set registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set image=holmes-dev:80e8e7ef \
  --set operator.registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set operator.image=holmes-operator-dev:80e8e7ef

Robusta wrapper chart:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set holmes.image=holmes-dev:80e8e7ef \
  --set holmes.operator.registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set holmes.operator.image=holmes-operator-dev:80e8e7ef

coderabbitai · 2026-02-24T07:56:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 15c1f34 and 102c2a8.

📒 Files selected for processing (1)

.github/workflows/build-and-test.yaml

💤 Files with no reviewable changes (1)

.github/workflows/build-and-test.yaml

Walkthrough

The pull request removes path-based filtering from the build-and-test GitHub Actions workflow's pull request trigger, allowing the workflow to execute on all pull requests rather than only on those modifying specific files.

Changes

Cohort / File(s)	Summary
Workflow Trigger Configuration `.github/workflows/build-and-test.yaml`	Removed path-based filtering constraints from PR trigger, causing workflow to run on all pull requests instead of being scoped to specific file changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Fix PRs blocked by skipped build-and-test check #1611: Modifies the same workflow file's path-based PR filtering with check-changes job and gating logic instead of simple removal.
Updating workflows to run only on code changes #511: Changes path-based filtering in the same workflow but in opposite direction—adding filters rather than removing them.
Skip build-and-test on docs-only changes, except HTTP API docs #1600: Directly modifies the same workflow file's trigger path filters for build-and-test.

Suggested reviewers

moshemorad
pavangudiwada

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: removing path filters from the build-and-test workflow to ensure it runs on all pull requests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

netlify · 2026-02-24T07:56:31Z

✅ Deploy Preview for holmes-docs ready!

Name	Link
🔨 Latest commit	`102c2a8`
🔍 Latest deploy log	https://app.netlify.com/projects/holmes-docs/deploys/699d5994c1ff3a0008a864d2
😎 Deploy Preview	https://deploy-preview-1633--holmes-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

aantn enabled auto-merge (squash) February 24, 2026 07:57

RoiGlinik approved these changes Feb 24, 2026

View reviewed changes

aantn merged commit ec214ae into master Feb 24, 2026
16 of 19 checks passed

aantn deleted the claude/fix-build-gate-docs-Hhqw9 branch February 24, 2026 07:59

Navigation Menu

Repository navigation

Remove path filters from build-and-test workflow - #1633

Remove path filters from build-and-test workflow#1633
aantn merged 1 commit into
masterfrom
claude/fix-build-gate-docs-Hhqw9

aantn commented Feb 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

aantn commented Feb 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Rationale

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Results of HolmesGPT evals

Results of HolmesGPT evals

Uh oh!

github-actions Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

netlify Bot commented Feb 24, 2026

✅ Deploy Preview for holmes-docs ready!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aantn commented Feb 24, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented Feb 24, 2026 •

edited

Loading

github-actions Bot commented Feb 24, 2026 •

edited

Loading

coderabbitai Bot commented Feb 24, 2026 •

edited

Loading