Repository navigation
Only run CLI Performance Benchmark on source changes - #1601
Conversation
Switch from paths-ignore to paths so the benchmark workflow only triggers when files that could affect CLI performance are modified: holmes/**, pyproject.toml, poetry.lock, the benchmark script, or the workflow itself. https://claude.ai/code/session_01XrNrjxLPQ4viTbe9bMVKFx Signed-off-by: Claude <noreply@anthropic.com>
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📂 Previous Runs📜 Run @ 0aae1a3 (#22218924963)✅ Results of HolmesGPT evalsAutomatically triggered by commit 0aae1a3 on branch Results of HolmesGPT evals
✅ Results of HolmesGPT evalsAutomatically triggered by commit ab9b802 on branch Results of HolmesGPT evals
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line): Run evals on a different branch (e.g., master) for comparison:
Quick re-run: Use Option 2: Trigger via GitHub Actions UI → "Run workflow" Option 3: Add PR labels to include extra evals in automatic regression runs:
Examples: 🏷️ Valid tags
Commands: CLI: |
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:916b4773
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:916b4773 me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:916b4773
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:916b4773Patch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:916b4773Robusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:916b4773 |
WalkthroughModified GitHub Actions workflow path filtering in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔬 CLI Performance Benchmark🟡 Startup Time (no LLM)Measures
🟡 Full CLI with LLMMeasures
PR: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/cli-performance.yaml:
- Around line 9-14: The workflow paths allowlist is missing two top-level
CLI-related files; update the paths array in
.github/workflows/cli-performance.yaml to include 'holmes_cli.py' and
'tempo_cli.py' alongside the existing entries (e.g., keep 'holmes/**',
'pyproject.toml', 'poetry.lock', 'scripts/cli_performance_benchmark.py', and
'.github/workflows/cli-performance.yaml') so changes to holmes_cli.py and
tempo_cli.py will trigger the workflow; if either file is truly unrelated to the
CLI startup, you may omit it, otherwise add both to be safe.
Switch from paths-ignore to paths so the benchmark workflow only triggers when files that could affect CLI performance are modified: holmes/**, pyproject.toml, poetry.lock, the benchmark script, or the workflow itself. https://claude.ai/code/session_01XrNrjxLPQ4viTbe9bMVKFx Signed-off-by: Claude <noreply@anthropic.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Optimized performance benchmark CI/CD workflow to trigger only on relevant code changes, reducing unnecessary workflow executions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Arik Alon <alon.arik@gmail.com>
Switch from paths-ignore to paths so the benchmark workflow only triggers when files that could affect CLI performance are modified: holmes/**, pyproject.toml, poetry.lock, the benchmark script, or the workflow itself. https://claude.ai/code/session_01XrNrjxLPQ4viTbe9bMVKFx Signed-off-by: Claude <noreply@anthropic.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Optimized performance benchmark CI/CD workflow to trigger only on relevant code changes, reducing unnecessary workflow executions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Mohse Morad <moshemorad12340@gmail.com>
Switch from paths-ignore to paths so the benchmark workflow only triggers when files that could affect CLI performance are modified: holmes/**, pyproject.toml, poetry.lock, the benchmark script, or the workflow itself. https://claude.ai/code/session_01XrNrjxLPQ4viTbe9bMVKFx Signed-off-by: Claude <noreply@anthropic.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Optimized performance benchmark CI/CD workflow to trigger only on relevant code changes, reducing unnecessary workflow executions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Mohse Morad <moshemorad12340@gmail.com>
Switch from paths-ignore to paths so the benchmark workflow only
triggers when files that could affect CLI performance are modified:
holmes/**, pyproject.toml, poetry.lock, the benchmark script, or the
workflow itself.
https://claude.ai/code/session_01XrNrjxLPQ4viTbe9bMVKFx
Signed-off-by: Claude noreply@anthropic.com
Summary by CodeRabbit