Skip to content

Clarify GCP project/region settings are defaults, not access restrictions - #1443

Merged
aantn merged 3 commits into
masterfrom
claude/clarify-gcp-docs-xN8Vr
Jan 28, 2026
Merged

Clarify GCP project/region settings are defaults, not access restrictions#1443
aantn merged 3 commits into
masterfrom
claude/clarify-gcp-docs-xN8Vr

Conversation

@aantn

@aantn aantn commented Jan 28, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

Updated GCP documentation and Helm chart values to clarify that project and region configuration settings define default values for gcloud commands, not access restrictions. This addresses potential confusion about whether these settings limit which GCP projects or regions can be queried.

Key Changes

  • Documentation updates: Enhanced inline comments in Kubernetes deployment manifests to clarify that environment variables set defaults, not limitations
  • Helm values clarification: Updated helm/holmes/values.yaml comments to explain that project and region settings don't restrict access
  • New explanatory notes: Added detailed "Understanding GCP_PROJECT_ID and GCP_REGION" and "Understanding project and region settings" sections in the GCP data source documentation with:
    • Clear explanation of default behavior
    • Examples showing how to override defaults with --project and --region flags
    • Clarification that IAM permissions (not these settings) determine actual access
    • Concrete example of querying a different project despite different default configuration

Implementation Details

  • Changes appear in both Holmes and Robusta Helm chart configuration sections
  • Consistent messaging across all documentation to prevent confusion
  • Added practical examples to help users understand the distinction between defaults and access control

https://claude.ai/code/session_01GMsFb29XmxVsTf2fzFAMy2

Summary by CodeRabbit

  • Documentation
    • Introduced a new "Project and Region Defaults" section clarifying optional settings and their default behavior.
    • Updated Kubernetes deployment examples with clearer annotations about default value usage.
    • Enhanced Helm chart configuration examples with improved descriptions for default value handling and fallback mechanisms.

✏️ Tip: You can customize this high-level summary in your review settings.

@netlify

netlify Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for holmes-docs ready!

Name Link
🔨 Latest commit 5717501
🔍 Latest deploy log https://app.netlify.com/projects/holmes-docs/deploys/697a1a64baf4c60008948237
😎 Deploy Preview https://deploy-preview-1443--holmes-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aantn / name: Natan Yellin (5717501)

@coderabbitai

coderabbitai Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Documentation and configuration comments updated to clarify Holmes project and region defaulting behavior. Added a new "Project and Region Defaults" section to the GCP data source documentation, and updated Helm chart and Kubernetes deployment examples with annotations explaining default fallback behavior.

Changes

Cohort / File(s) Summary
GCP Documentation Updates
docs/data-sources/builtin-toolsets/gcp.md		 Added "Project and Region Defaults" section explaining optional project/region settings. Updated Kubernetes environment variable annotations and Helm chart examples to clarify Holmes uses these values as defaults when not explicitly provided. Removed "Optional" annotation from primary project/region fields.
Helm Chart Configuration Comments
helm/holmes/values.yaml		 Updated comments for mcpAddons.config.project and mcpAddons.config.region fields to indicate Holmes uses these as defaults. No changes to values or behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • GCP MCP integration #1310: Related GCP MCP integration changes that introduced the project/region defaulting feature being documented and clarified in this PR.

Suggested reviewers

  • arikalon1
  • RoiGlinik
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main objective of the PR: clarifying that GCP project/region settings define defaults rather than access restrictions, which aligns with the documentation and Helm chart updates throughout the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📂 Previous Runs

📜 Run @ 0258167 (#21437619376)

✅ Results of HolmesGPT evals

Automatically triggered by commit 0258167 on branch claude/clarify-gcp-docs-xN8Vr

View workflow logs

Results of HolmesGPT evals

  • ask_holmes: 9/9 test cases were successful, 0 regressions
Status Test case Time Turns Tools Cost
✅ 09_crashpod 28.2s ±0% 5 9 $0.2072
✅ 101_loki_historical_logs_pod_deleted 41.7s ↓28% 6 10 $0.2491
✅ 111_pod_names_contain_service 22.5s ↓11% 4 7 $0.1771
✅ 12_job_crashing 35.4s ±0% 5 15 $0.2609
✅ 162_get_runbooks 40.8s ±0% 6 11 $0.2713
✅ 176_network_policy_blocking_traffic_no_runbooks 45.6s ±0% 7 17 $0.2931
✅ 24_misconfigured_pvc 35.5s ±0% 6 13 $0.2361
✅ 43_current_datetime_from_prompt 4.3s ±0% 1 — $0.1019
✅ 61_exact_match_counting 16.3s ±0% 4 4 $0.1592
Total 30.0s avg 4.9 avg 10.8 avg $1.9559

Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%.

Historical Comparison Details

Filter: excluding branch 'claude/clarify-gcp-docs-xN8Vr'

Status: Success - 45 test/model combinations loaded

Experiments compared (30):

Comparison indicators:

  • ±0% — diff under 10% (within noise threshold)
  • ↑N%/↓N% — diff 10-25%
  • ↑N%/↓N% — diff over 25% (significant)
📜 Run @ 406915b (#21437380212)

✅ Results of HolmesGPT evals

Automatically triggered by commit 406915b on branch claude/clarify-gcp-docs-xN8Vr

View workflow logs

Results of HolmesGPT evals

  • ask_holmes: 9/9 test cases were successful, 0 regressions
Status Test case Time Turns Tools Cost
✅ 09_crashpod 33.7s ↑14% 5 11 $0.2253
✅ 101_loki_historical_logs_pod_deleted 69.7s ↑21% 9 19 $0.3753
✅ 111_pod_names_contain_service 24.1s ±0% 4 7 $0.1773
✅ 12_job_crashing 37.0s ±0% 5 13 $0.2515
✅ 162_get_runbooks 41.3s ±0% 6 11 $0.2726
✅ 176_network_policy_blocking_traffic_no_runbooks 48.3s ↑11% 7 19 $0.3192
✅ 24_misconfigured_pvc 35.2s ±0% 6 13 $0.2388
✅ 43_current_datetime_from_prompt 4.5s ±0% 1 — $0.1019
✅ 61_exact_match_counting 16.4s ±0% 4 4 $0.1592
Total 34.5s avg 5.2 avg 12.1 avg $2.1212

Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%.

Historical Comparison Details

Filter: excluding branch 'claude/clarify-gcp-docs-xN8Vr'

Status: Success - 10 test/model combinations loaded

Experiments compared (30):

Comparison indicators:

  • ±0% — diff under 10% (within noise threshold)
  • ↑N%/↓N% — diff 10-25%
  • ↑N%/↓N% — diff over 25% (significant)
📜 Run @ df785f5 (#21437155159)

✅ Results of HolmesGPT evals

Automatically triggered by commit df785f5 on branch claude/clarify-gcp-docs-xN8Vr

View workflow logs

Results of HolmesGPT evals

  • ask_holmes: 9/9 test cases were successful, 0 regressions
Status Test case Time Turns Tools Cost
✅ 09_crashpod 30.6s ±0% 5 11 $0.2299
✅ 101_loki_historical_logs_pod_deleted 61.8s ±0% 9 17 $0.3659
✅ 111_pod_names_contain_service 24.3s ±0% 4 8 $0.1845
✅ 12_job_crashing 37.2s ±0% 5 12 $0.2494
✅ 162_get_runbooks 37.5s ±0% 6 11 $0.2632
✅ 176_network_policy_blocking_traffic_no_runbooks 41.3s ±0% 6 14 $0.2727
✅ 24_misconfigured_pvc 34.7s ±0% 6 13 $0.2394
✅ 43_current_datetime_from_prompt 4.2s ±0% 1 — $0.1019
✅ 61_exact_match_counting 15.6s ±0% 4 4 $0.1589
Total 31.9s avg 5.1 avg 11.2 avg $2.0659

Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%.

Historical Comparison Details

Filter: excluding branch 'claude/clarify-gcp-docs-xN8Vr'

Status: Success - 46 test/model combinations loaded

Experiments compared (30):

Comparison indicators:

  • ±0% — diff under 10% (within noise threshold)
  • ↑N%/↓N% — diff 10-25%
  • ↑N%/↓N% — diff over 25% (significant)

✅ Results of HolmesGPT evals

Automatically triggered by commit 5717501 on branch claude/clarify-gcp-docs-xN8Vr

View workflow logs

⚠️ No eval report was generated.

📖 Legend
Icon Meaning
✅ The test was successful
➖ The test was skipped
⚠️ The test failed but is known to be flaky or known to fail
🚧 The test had a setup failure (not a code regression)
🔧 The test failed due to mock data issues (not a code regression)
🚫 The test was throttled by API rate limits/overload
❌ The test failed and should be fixed before merging the PR
🔄 Re-run evals manually

⚠️ Warning: /eval comments always run using the workflow from master, not from this PR branch. If you modified the GitHub Action (e.g., added secrets or env vars), those changes won't take effect.

To test workflow changes, use the GitHub CLI or Actions UI instead:

gh workflow run eval-regression.yaml --repo HolmesGPT/holmesgpt --ref claude/clarify-gcp-docs-xN8Vr -f markers=regression -f filter=

Option 1: Comment on this PR with /eval:

/eval
markers: regression

Or with more options (one per line):

/eval
model: gpt-4o
markers: regression
filter: 09_crashpod
iterations: 5

Run evals on a different branch (e.g., master) for comparison:

/eval
branch: master
markers: regression
Option Description
model Model(s) to test (default: same as automatic runs)
markers Pytest markers (no default - runs all tests!)
filter Pytest -k filter (use /list to see valid eval names)
iterations Number of runs, max 10
branch Run evals on a different branch (for cross-branch comparison)

Quick re-run: Use /rerun to re-run the most recent /eval on this PR with the same parameters.

Option 2: Trigger via GitHub Actions UI → "Run workflow"

🏷️ Valid markers

(loading...)

Commands: /eval · /rerun · /list

CLI: gh workflow run eval-regression.yaml --repo HolmesGPT/holmesgpt --ref claude/clarify-gcp-docs-xN8Vr -f markers=regression -f filter=

@github-actions

github-actions Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Docker image ready for 280ab27 (built in 43s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:280ab27
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:280ab27 me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:280ab27
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:280ab27

Patch Helm values in one line (choose the chart you use):

HolmesGPT chart:

helm upgrade --install holmesgpt ./helm/holmes \
  --set registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set image=holmes-dev:280ab27

Robusta wrapper chart:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set holmes.image=holmes-dev:280ab27

@aantn
aantn force-pushed the claude/clarify-gcp-docs-xN8Vr branch 4 times, most recently from 23a4db3 to 2d7e185 Compare January 28, 2026 12:06
@claude
docs: clarify that GCP project/region settings are defaults, not limi…
68f6783 
…tations

Add a concise explanation in the Overview section explaining that:
- project/region settings specify where Holmes looks first by default
- Holmes can investigate any project/region the service account has IAM access to

Simplified inline comments and removed duplicate notes across config sections.

https://claude.ai/code/session_01GMsFb29XmxVsTf2fzFAMy2
Signed-off-by: Claude <noreply@anthropic.com>
@aantn
aantn force-pushed the claude/clarify-gcp-docs-xN8Vr branch from 2d7e185 to 68f6783 Compare January 28, 2026 12:08
@aantn
aantn enabled auto-merge (squash) January 28, 2026 12:08
@aantn
aantn merged commit 148cf90 into master Jan 28, 2026
15 of 17 checks passed
@aantn
aantn deleted the claude/clarify-gcp-docs-xN8Vr branch January 28, 2026 14:23
@coderabbitai coderabbitai Bot mentioned this pull request Feb 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arikalon1 arikalon1 arikalon1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aantn @arikalon1 @claude