Remove deprecated workload health - #1380
Conversation
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Resolve merge conflicts by keeping HEAD's removal of workload health endpoints: - Remove WorkloadHealthRequest and WorkloadHealthChatRequest imports - Remove /api/workload_health_check and /api/workload_health_chat endpoints - Delete tests/llm/test_workload_health.py test file - Remove test_workload_health from LLM_TEST_TYPES Keep ToolCallConversationResult import in conversations.py as it's used elsewhere. Signed-off-by: Claude <noreply@anthropic.com>
|
|
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThis PR removes the workload health feature across the codebase: API endpoints, core models, conversation builders, Supabase DAL method, prompt templates, LLM fixtures/tests, and related reporting/test-infrastructure hooks. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📂 Previous Runs📜 Run @ 9d90443 (#21492814514)✅ Results of HolmesGPT evalsAutomatically triggered by commit 9d90443 on branch 📜 Run @ e19dcb0 (#21397191995)✅ Results of HolmesGPT evalsAutomatically triggered by commit e19dcb0 on branch Results of HolmesGPT evals
Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%. Historical Comparison DetailsFilter: excluding branch 'claude/merge-master-gbQOa' Status: Success - 12 test/model combinations loaded Experiments compared (30):
Comparison indicators:
📜 Run @ 69c1c64 (#21227284890)✅ Results of HolmesGPT evalsAutomatically triggered by commit 69c1c64 on branch Results of HolmesGPT evals
Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%. Historical Comparison DetailsFilter: excluding branch 'claude/merge-master-gbQOa' Status: Success - 29 test/model combinations loaded Experiments compared (30):
Comparison indicators:
📜 Run @ 5cbf1a2 (#21227188757)✅ Results of HolmesGPT evalsAutomatically triggered by commit 5cbf1a2 on branch 📜 Run @ 2ad5afc (#21131599992)✅ Results of HolmesGPT evalsAutomatically triggered by commit 2ad5afc on branch ✅ Results of HolmesGPT evalsAutomatically triggered by commit f2a1770 on branch Results of HolmesGPT evals
Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%. Historical Comparison DetailsFilter: excluding branch 'claude/merge-master-gbQOa' Status: Success - 9 test/model combinations loaded Experiments compared (30):
Comparison indicators:
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line): Run evals on a different branch (e.g., master) for comparison:
Quick re-run: Use Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
Commands: CLI: |
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:e795a40
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:e795a40 me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:e795a40
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:e795a40Patch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:e795a40Robusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:e795a40 |
These functions were incorrectly removed during merge conflict resolution. They are new features from master unrelated to workload health removal. Signed-off-by: Claude <noreply@anthropic.com>
Resolve merge conflicts: - server.py: Remove workload health endpoints (intentionally removed in HEAD) - tests/test_server_endpoints.py: Remove workload health test, keep new TestExtractPassthroughHeaders test class Maintain workload health removal while incorporating new features: - Request context passthrough for all endpoints - New bash validation tests and kubectl-run toolset - Scheduled prompts feature - Various toolset improvements Signed-off-by: Claude <noreply@anthropic.com>
Summary by CodeRabbit
Documentation
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.