Remove post-processing support - #1279
Merged
aantn merged 5 commits intoJan 1, 2026
Merged
Conversation
Signed-off-by: Codex <codex@openai.com>
Contributor
WalkthroughThis PR removes the post-processing prompt feature by deleting its environment variable, Helm values, documentation, function parameters, call sites, and tests that supplied it, and by adding a small test config file. No new runtime behavior beyond omission of post-processing remains. Changes
Sequence Diagram(s)Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
💤 Files with no reviewable changes (4)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Comment |
…ocessing-capability
Contributor
✅ Results of HolmesGPT evalsAutomatically triggered by commit 4fda527 Results of HolmesGPT evals
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line):
Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
📋 Valid eval names (use with filter)test_ask_holmes:
test_investigate:
|
Contributor
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:5267acd
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:5267acd me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:5267acd
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:5267acdPatch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:5267acdRobusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:5267acd |
…ocessing-capability
Collaborator
Author
|
@copilot remove evals_per_branch.json |
7 tasks
Contributor
Contributor
✅ Results of HolmesGPT evalsAutomatically triggered by commit af79aa8 on branch Results of HolmesGPT evals
Time/Cost columns compare each test+model pair against its own historical average from other branches (↑slower/costlier, ↓faster/cheaper). Historical data available for 14 unique test+model pairs. Historical Comparison DetailsFilter: excluding branch 'codex/linear-mention-rob-98-remove-post-processing-capability' Status: Success - 14 test/model combinations loaded Experiments compared (30):
Comparison indicators:
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line): Run evals on a different branch (e.g., master) for comparison:
Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
📋 Valid eval names (use with filter)test_ask_holmes:
test_investigate:
|
Removed `evals_per_branch.json` file that was added as part of the post-processing removal PR but is no longer needed. Checklist for the toolset: - [ ] Toolset has unit tests where relevant - [ ] Toolset has both ask_holmes and investigate evals - [ ] Toolset has a documentation - [ ] Toolset has the correct is_default flag - [ ] Toolset returns a correct `get_example_config` - [ ] Toolset does a live health check in addition to checking for correct configuration - [ ] Create a demo video (if relevant) <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aantn <494087+aantn@users.noreply.github.com>
|
|
Contributor
✅ Results of HolmesGPT evalsAutomatically triggered by commit d7ea020 on branch Results of HolmesGPT evals
Time/Cost columns compare each test+model pair against its own historical average from other branches (↑slower/costlier, ↓faster/cheaper). Historical data available for 12 unique test+model pairs. Historical Comparison DetailsFilter: excluding branch 'codex/linear-mention-rob-98-remove-post-processing-capability' Status: Success - 12 test/model combinations loaded Experiments compared (30):
Comparison indicators:
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line): Run evals on a different branch (e.g., master) for comparison:
Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
📋 Valid eval names (use with filter)test_ask_holmes:
test_investigate:
|
Collaborator
Author
|
@copilot is additionalInstructions in the custom toolsets actually used anywhere? or should it be removed entirely |
Contributor
moshemorad
approved these changes
Jan 1, 2026
…ocessing-capability
|
aantn
enabled auto-merge (squash)
January 1, 2026 10:27
aantn
deleted the
codex/linear-mention-rob-98-remove-post-processing-capability
branch
January 1, 2026 10:28
Contributor
✅ Results of HolmesGPT evalsAutomatically triggered by commit bfae6d8 on branch Results of HolmesGPT evals
Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%. Historical Comparison DetailsFilter: excluding branch 'codex/linear-mention-rob-98-remove-post-processing-capability' Status: Success - 18 test/model combinations loaded Experiments compared (30):
Comparison indicators:
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line): Run evals on a different branch (e.g., master) for comparison:
Quick re-run: Use Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
📋 Valid eval names (use with filter)test_ask_holmes:
test_investigate:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task
Summary by CodeRabbit
Documentation
Configuration
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.