Repository navigation
Optimize Docker Build on PR: add caching and build amd64 only - #1257
Conversation
- Add GitHub Actions cache (cache-from/cache-to type=gha) for Docker layers - Build only linux/amd64 for PR builds (ARM64 builds on release) - Update PR comments to clearly indicate amd64-only architecture This should significantly reduce build times by: 1. Caching Docker layers between builds 2. Avoiding slow QEMU emulation for ARM64 builds Signed-off-by: Claude <noreply@anthropic.com>
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:134935b
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:134935b me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:134935b
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:134935bPatch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:134935bRobusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:134935b |
WalkthroughModifies the GitHub Actions Docker workflow to restrict PR builds to x64-only architecture (removing ARM64 support), replaces build-args with GitHub Actions cache management (cache-from/cache-to), and adds messaging indicating x64-only scope with warnings that ARM images are unavailable in PR builds. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/docker-dev-images.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build
- GitHub Check: build (3.10)
- GitHub Check: build (3.11)
- GitHub Check: llm_evals
- GitHub Check: build (3.12)
🔇 Additional comments (4)
.github/workflows/docker-dev-images.yaml (4)
118-118: LGTM!Clear messaging to inform users about the x64-only build scope in PR builds.
175-186: LGTM!The x64-only platform restriction and GHA caching are appropriate optimizations for PR builds. Non-fork PRs have the necessary permissions to both read and write to the GitHub Actions cache.
191-191: LGTM!Consistent messaging in the build logs.
220-258: LGTM!The ARM warning is prominently placed and clearly explains the limitation. Good user experience to inform developers upfront before they attempt to use the image on ARM infrastructure.
Results of HolmesGPT evals
Legend
|
Before: 15m builds

After: 3m builds
