Add image link comments to docker workflows by aantn · Pull Request #1210 · HolmesGPT/holmesgpt

aantn · 2025-12-21T12:25:03Z

Summary

add automated comments to dev docker build workflow with links to built images
add automated comments to release docker build workflow with links to built images and tags
adjust workflow permissions to allow posting comments on PRs or commits

Testing

not run (not needed for workflow changes)

Codex Task

Summary by CodeRabbit

Chores
- Improved CI/CD workflow to automatically post Docker image details and registry links in pull request and commit comments.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-21T12:25:15Z

Walkthrough

The workflow file is updated with elevated permissions and a new step that automatically posts Docker image details and registry links as comments on associated pull requests or commits after the build completes.

Changes

Cohort / File(s)	Summary
Workflow permissions and Docker image commenting `\.github/workflows/docker-dev-images\.yaml`	Updated workflow permissions: `contents` permission changed from `read` to `write`; added `pull-requests` permission with `write` access. Added new "Comment with image details" step using `actions/github-script@v7` that constructs Docker image tags, derives repo metadata (owner, repo, branch, sha), fetches open PRs for the current branch, and posts a comment with image tags and registry link to either the associated PR or directly to the commit.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Verify that the updated workflow permissions (contents:write, pull-requests:write) are appropriate and minimally sufficient
Validate the script logic for constructing short and long image tags, registry URL formation, and PR/commit detection
Confirm proper error handling and logging output

Possibly related PRs

HolmesGPT/holmesgpt#964: Implements the initial Docker build-and-push workflow that this PR enhances with post-build commenting functionality.

Suggested reviewers

moshemorad

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding automated image link comments to Docker workflows.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f1d3a3 and c1f10ddcc0ca82b951d6e288dfeb3a0124c03b91.

📒 Files selected for processing (2)

.github/workflows/build-docker-images.yaml (2 hunks)
.github/workflows/docker-dev-images.yaml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: llm_evals
GitHub Check: build (3.10)
GitHub Check: build (3.12)
GitHub Check: build (3.11)
GitHub Check: build

🔇 Additional comments (3)

.github/workflows/build-docker-images.yaml (1)

13-15: Permission updates are appropriate for the new comment functionality.

The changes enable the workflow to post comments:

contents: write is required for repos.createCommitComment API

pull-requests: write is required for issues.createComment API on PRs

.github/workflows/docker-dev-images.yaml (2)

13-15: Permission updates are appropriate for the new comment functionality.

The changes enable the workflow to post comments:

contents: write is required for repos.createCommitComment API

pull-requests: write is required for issues.createComment API on PRs

58-104: Well-implemented comment step with appropriate PR lookup logic.

The implementation correctly:

Extracts branch and commit information from the context

Constructs registry links for both full SHA and short SHA tags

Uses proper line break escaping (.join('\n') on line 79)

Searches for open PRs matching the branch name, which is appropriate for a push workflow

Falls back to commit comments when no PR exists

github-actions · 2025-12-21T12:39:28Z

Dev Docker images are ready for this commit:

Use either tag to pull the image for testing.

github-actions · 2025-12-21T12:57:13Z

Dev Docker images are ready for this commit:

Use either tag to pull the image for testing.

github-actions · 2025-12-21T13:56:57Z

Dev Docker images are ready for this commit:

Use either tag to pull the image for testing.

Signed-off-by: Robusta Runner <aantny@gmail.com>

1. Add runbook alerts to runbook prompts so llm will be able to select it. 2. Remove old alert runbook fetching as part of invesigation 3. Add eval for alert with multiple relevant runbooks due to matching alert - Test report here: https://www.braintrust.dev/app/robustadev/p/HolmesGPT/experiments/root-master-k%3D165_-20251218_145120?c= 4. Removed responses logs that spammed test logs.  ## Summary by CodeRabbit # Release Notes * **New Features** * Enhanced runbook matching to include alert-based matching in addition to symptom-based matching, improving runbook discovery accuracy. * Added alerts metadata to runbook catalog entries for better runbook relevance filtering. * **Chores** * Simplified investigation workflow by streamlining instruction data flow. * Improved test coverage with new integration test for multi-runbook alert scenarios. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>  --------- Signed-off-by: Mohse Morad <moshemorad12340@gmail.com> Signed-off-by: Robusta Runner <aantny@gmail.com>

…workflows-in-holmes-re

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/docker-dev-images.yaml (1)

58-104: Implementation is correct; consider handling multiple PRs and comment duplication.

The logic correctly handles both PR and commit scenarios with appropriate API calls. The head parameter format ${owner}:${branch} is valid for filtering PRs.

Two minor considerations for a production workflow:

Multiple PRs from same branch: If multiple open PRs exist from the same branch (each targeting different bases), only the first receives a comment. While unlikely in typical workflows, consider logging or commenting on all matching PRs if needed.

Duplicate comments: Each push creates a new comment without checking for existing ones. With frequent commits, this generates noise. Consider updating an existing recent comment or checking for duplicates before posting.

These are refinements for robustness and don't block the current implementation.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1f10ddcc0ca82b951d6e288dfeb3a0124c03b91 and acd14d0.

📒 Files selected for processing (1)

.github/workflows/docker-dev-images.yaml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: build (3.11)
GitHub Check: build (3.12)
GitHub Check: build (3.10)
GitHub Check: llm_evals
GitHub Check: build

🔇 Additional comments (1)

.github/workflows/docker-dev-images.yaml (1)

12-15: Reconsider contents: write permission for commit comments.

The pull-requests: write permission is correctly needed for PR comments. However, contents: write allows broader repository modifications. GitHub's documentation is unclear about which permission is actually required for repos.createCommitComment—some sources indicate it works without explicit permissions, while others confirm contents: write is necessary. Consider testing whether this workflow actually requires contents: write, or alternatively, limit commenting to pull requests only (which requires only pull-requests: write).

github-actions · 2025-12-21T18:18:11Z

Dev Docker images are ready for this commit:

Use either tag to pull the image for testing.

github-actions · 2025-12-21T18:19:02Z

Dev Docker images are ready for this commit:

Use either tag to pull the image for testing.

github-actions · 2025-12-21T18:20:13Z

Results of HolmesGPT evals

ask_holmes: 31/37 test cases were successful, 2 regressions, 1 setup failures, 3 mock failures

Test suite	Test case	Status
ask	01_how_many_pods	✅
ask	02_what_is_wrong_with_pod	✅
ask	04_related_k8s_events	✅
ask	05_image_version	✅
ask	09_crashpod	✅
ask	10_image_pull_backoff	✅
ask	110_k8s_events_image_pull	✅
ask	11_init_containers	✅
ask	13a_pending_node_selector_basic	✅
ask	14_pending_resources	✅
ask	15_failed_readiness_probe	✅
ask	163_compaction_follow_up	✅
ask	17_oom_kill	❌
ask	18_oom_kill_from_issues_history	❌
ask	19_detect_missing_app_details	✅
ask	20_long_log_file_search	✅
ask	24_misconfigured_pvc	✅
ask	24a_misconfigured_pvc_basic	✅
ask	28_permissions_error	🚧
ask	39_failed_toolset	✅
ask	41_setup_argo	✅
ask	42_dns_issues_steps_new_tools	✅
ask	43_current_datetime_from_prompt	✅
ask	45_fetch_deployment_logs_simple	✅
ask	51_logs_summarize_errors	✅
ask	53_logs_find_term	✅
ask	54_not_truncated_when_getting_pods	✅
ask	59_label_based_counting	✅
ask	60_count_less_than	✅
ask	61_exact_match_counting	✅
ask	63_fetch_error_logs_no_errors	✅
ask	79_configmap_mount_issue	✅
ask	83_secret_not_found	✅
ask	86_configmap_like_but_secret	✅
ask	93_calling_datadog[0]	🔧
ask	93_calling_datadog[1]	🔧
ask	93_calling_datadog[2]	🔧

Legend

✅ the test was successful
:minus: the test was skipped
⚠️ the test failed but is known to be flaky or known to fail
🚧 the test had a setup failure (not a code regression)
🔧 the test failed due to mock data issues (not a code regression)
🚫 the test was throttled by API rate limits/overload
❌ the test failed and should be fixed before merging the PR

## Summary - add automated comments to dev docker build workflow with links to built images - add automated comments to release docker build workflow with links to built images and tags - adjust workflow permissions to allow posting comments on PRs or commits ## Testing - not run (not needed for workflow changes) ------ [Codex Task](https://chatgpt.com/codex/tasks/task_b_6947d623f1a8832797c92848985d3af4)  ## Summary by CodeRabbit * **Chores** * Updated CI/CD workflows to automatically post Docker image build details and registry links as comments on pull requests or commits. Comments provide full and short image tags along with registry information upon image release. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>  --------- Signed-off-by: Robusta Runner <aantny@gmail.com> Signed-off-by: Mohse Morad <moshemorad12340@gmail.com> Co-authored-by: moshemorad <moshemorad12340@gmail.com> Signed-off-by: Filip Grebowski <grebowskifilip@gmail.com>

aantn added the codex label Dec 21, 2025 — with ChatGPT Codex Connector

coderabbitai Bot reviewed Dec 21, 2025

View reviewed changes

Comment thread .github/workflows/build-docker-images.yaml Outdated

aantn requested a review from moshemorad December 21, 2025 13:05

aantn and others added 3 commits December 21, 2025 20:03

Add image link comments to docker workflows

5b4a21e

Signed-off-by: Robusta Runner <aantny@gmail.com>

Remove release workflow commenting

8821c5e

Signed-off-by: Robusta Runner <aantny@gmail.com>

aantn force-pushed the codex/linear-mention-rob-26-update-github-workflows-in-holmes-re branch from 58d1c0c to 727e133 Compare December 21, 2025 18:03

Merge branch 'master' into codex/linear-mention-rob-26-update-github-…

acd14d0

…workflows-in-holmes-re

aantn enabled auto-merge (squash) December 21, 2025 18:05

coderabbitai Bot reviewed Dec 21, 2025

View reviewed changes

moshemorad approved these changes Dec 21, 2025

View reviewed changes

aantn merged commit af8b2a5 into master Dec 21, 2025
10 of 11 checks passed

aantn deleted the codex/linear-mention-rob-26-update-github-workflows-in-holmes-re branch December 21, 2025 18:24

This was referenced Dec 23, 2025

Add retention warning to dev image PR comments #1224

Merged

fix docker image notifications #1245

Merged

coderabbitai Bot mentioned this pull request Dec 28, 2025

Skip building images on PRs from external users (forks) #1249

Merged

coderabbitai Bot mentioned this pull request Feb 11, 2026

Rob 2788 add docs #1547

Merged

Navigation Menu

Repository navigation

Add image link comments to docker workflows - #1210

Add image link comments to docker workflows#1210
aantn merged 4 commits into
masterfrom
codex/linear-mention-rob-26-update-github-workflows-in-holmes-re

aantn commented Dec 21, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Dec 21, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

coderabbitai Bot left a comment

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aantn commented Dec 21, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

github-actions Bot commented Dec 21, 2025

Uh oh!

github-actions Bot commented Dec 21, 2025

Results of HolmesGPT evals

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aantn commented Dec 21, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Dec 21, 2025 •

edited

Loading