fix: correct venv installation path in dockerfile - #1181
Merged
Merged
Conversation
mainred
force-pushed
the
mainred/fix-venv-path
branch
from
December 10, 2025 15:29
5f393da to
42d598a
Compare
Signed-off-by: Qingchuan Hao <qingchuan.hao@microsoft.com>
mainred
force-pushed
the
mainred/fix-venv-path
branch
from
December 10, 2025 15:29
42d598a to
d34bd2b
Compare
Collaborator
Author
|
The background is we are delivering containerized holmes CLI, and we want to run evals in the pod with poetry command. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In build stage of dockerfile, the virtual venv is installed under /app, since poetry installs python executables like poetry with the interpreter "/app/venv/bin/python", but we copied venv from builder to /venv in the docker image, leading to the failure of executing the python tool:
bash: /venv/bin/poetry: cannot execute: required file not foundTo make /app folder clean with only holmes related files, I keep the venv under /, so the change is mainly under builder by changing the workdir to /
Tests