Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Pixel maximum menu width" not working as expected #319

Closed
chip33 opened this issue Feb 7, 2022 · 8 comments
Closed

[BUG] "Pixel maximum menu width" not working as expected #319

chip33 opened this issue Feb 7, 2022 · 8 comments
Assignees
Milestone

Comments

@chip33
Copy link
Contributor

chip33 commented Feb 7, 2022

Description, Steps to reproduce, Expected behavior, Screenshots

I was hoping to put in a feature request to enable a "Pixel minimum menu width"
where you could set a minimum width and the window width would shrink to that size but expand if longer filenames were found in the directory.
This would be similar to how the Quick Launch menu works now expanding in width (to a set maximum) as the filename grows longer.
Quick Launch

"Pixel maximum menu height" works as expected but changing "Pixel maximum menu width" between its limits of 50 to 1000 pixels has no visible effect on the STM window width which always looks like this.
Screenshot 2022-02-07 143840

Is this a bug in "Pixel maximum menu width" ?
If you feel that adding a "Pixel miniimum menu width" is a good feature I could convert this to a request later.
Thank you for all your work on this project!

@Hofknecht
Copy link
Owner

Hofknecht commented Feb 7, 2022

With "Pixel miniimum menu width" i am not sure, for me it is enough that minimum is smalles text and there is a fixed minimum, you can see e.g. here
2022-02-07 17_59_57-Window

related to bug in "Pixel maximum menu width", i set e.g. 900 made a short test with 'XXXXX...' and seems to work
2022-02-07 17_59_03-Window
(there is a known issue that measure string is not perfect accurate e.g. when using lllllllll it measures too short, but for X it probably measures a little bit too much)

when i reduce to e.g. 150 it looks like this
2022-02-07 18_05_39-Window

so basically should work.

What is it configured in your last screenshot and does it not change anything when you change the value?

@chip33
Copy link
Contributor Author

chip33 commented Feb 7, 2022

Ah yes, thank you for your screenshots they are really helpful.

Turns out it is only an issue at high resolutions.

I tried it at 1080p and everything works perfectly and the window shrinks very narrow to fit short filenames like in your images and expands hugely to fit long filenames.

At 4k (at 300% scaling) for some reason Windows stops the window from shrinking below about 800px
As the maximum pixel width is 1000 there is almost no difference.
At 350% scaling the STM window never shrinks below 1000px so there is no difference at all.

Making the maximum width go above 1000 which is only 1/4 of the screen would show that it is working.
The not going below 800px even when set to 100px width may be a windows scaling thing rather than a setting in STM, I am not sure.

4k @ 300% display scaling 100px maximum width:

Screenshot 2022-02-07 190314

4k @ 300% display scaling 1000px maximum width:

Screenshot 2022-02-07 184404

4k @ 350% display scaling 100px maximum width:

Screenshot 2022-02-07 195604

4k @ 350% display scaling 1000px maximum width:

Screenshot 2022-02-07 185127

@Hofknecht Hofknecht added this to the 1.3 milestone Feb 7, 2022
@Hofknecht Hofknecht self-assigned this Feb 7, 2022
@Hofknecht Hofknecht changed the title [BUG] ? "Pixel maximum menu width" not working as expected [BUG] "Pixel maximum menu width" not working as expected Feb 11, 2022
@Hofknecht
Copy link
Owner

@chip33
solved with 1.2.6.4

do you want to test it and check if it works now as expected?
do you still want to configure a minimum width?

@chip33
Copy link
Contributor Author

chip33 commented Feb 11, 2022

Thank you very much for looking at this.
The issue of it not going above 1000px width which is needed for 4K is fixed and tested.
The issue of it not going below ≈ 800px at 4k @ 300% display scaling and 1000px at 4k @ 350% is still there.

The major issue has been fixed but it would be nice if the window would shrink to fit the filenames in 4K as well.

This is the minimum width it will shrink to at 4K 350% scaling:

Screenshot 2022-02-07 195604

@chip33
Copy link
Contributor Author

chip33 commented Feb 11, 2022

Maybe windows is multiplying the minimum width by 350% and that is why?
In that case changing the minimum width could help.

@Hofknecht
Copy link
Owner

Hofknecht commented Feb 11, 2022

@chip33
Thank you for testing.

We made 2 mistakes at the redesign 1.2. Now we also tested correct, was a bit tricky with normal screens to test 350%. : )
now should be solved
can you try again?

@Hofknecht
Copy link
Owner

@chip33
If you notice any other 4k scaling problems, please feel free to create issues for them.
Even if you still want to set a minimum size you can just create an issue

@chip33
Copy link
Contributor Author

chip33 commented Feb 11, 2022

Thank you so much, great job finding this :)
The whole issue is solved.

Here it is working now at 4k 350%

Screenshot 2022-02-11 214911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants