Rings: remove some universe variables #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdchristensen
commented
Jun 12, 2024
| @@ -2,6 +2,9 @@ Require Import Basics.Overture Basics.Decidable Spaces.Nat. | |||
| Require Import Algebra.Rings.Ring. | |||
| Require Import Classes.interfaces.abstract_algebra. | |||
|
|
|||
| Local Set Universe Minimization ToSet. | |||
There was a problem hiding this comment.
This gets rid of lots of universe variables.
| @@ -111,7 +115,7 @@ Proof. | |||
| + rewrite (kronecker_delta_neq p). | |||
| rewrite rng_mult_zero_l. | |||
| rewrite grp_unit_l. | |||
| f_ap; apply path_ishprop. | |||
| apply ap, path_ishprop. | |||
There was a problem hiding this comment.
The changes to this proof only get rid of one universe variable.
Signed-off-by: Ali Caglayan <[email protected]>
jdchristensen
commented
Jun 12, 2024
|
I'm happy to merge this for now, and do additional work in another PR, unless @Alizter plans to add more to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a start at removing some universe variables in Rings/*.
@Alizter , please feel free to contribute to this PR, as I may not have time to investigate further. Or we can merge this and look at other things later.