Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump min version to 8.19 #1985

Merged
merged 5 commits into from
Jun 9, 2024
Merged

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Jun 7, 2024

We bump our minimal Coq version to 8.19.

This version appears to have some better universe inference and will be useful for #1984.

I did a compatibility cleanup in No/Core.v.

I noticed that there is an 8.19 compatibility comment in Quotient.v but I couldn't work out what exactly could change. @jdchristensen would you mind taking a look at that file and dropping the 8.18 compat? (Alternatively, we can do that in a later PR it doesn't seem too pressing).

The draft PR #1862 can be undrafted after this.

Signed-off-by: Ali Caglayan <[email protected]>

<!-- ps-id: 3096276a-e750-4279-a80d-852676b72264 -->
@jdchristensen
Copy link
Collaborator

I did a compatibility cleanup in No/Core.v.

Did you forget to include this? Do you want me to push changes to Quotient.v to this PR?

@Alizter
Copy link
Collaborator Author

Alizter commented Jun 7, 2024

@jdchristensen Just forgot to push. You can go ahead and push changes to Quotient.v here.

@jdchristensen
Copy link
Collaborator

@Alizter This LGTM, but I don't know why the CI isn't running for my latest commit.

@jdchristensen
Copy link
Collaborator

Ok, the CI is running now, but one of the nix jobs is still at 8.18.

@jdchristensen
Copy link
Collaborator

I tried changing an "8.18" to "8.19" in flake.nix, but the build still seems to be using 8.18. I don't know anything about nix, so I'll leave this to @Alizter .

@Alizter
Copy link
Collaborator Author

Alizter commented Jun 7, 2024

@jdchristensen Yes, I forgot to change that. There was a new version of coq-lsp released so I'd lile to wait a tad longer before updating the nix stuff.

Signed-off-by: Ali Caglayan <[email protected]>
@Alizter
Copy link
Collaborator Author

Alizter commented Jun 9, 2024

I've updated the nix flake to a version that includes the latest coq-lsp which was released this week. The issue from before was because the Nix flake's lockfile was not updated, which can be done by nix flake check or nix develop. And since we are updating the lockfile I decided we might as well bump to the latest available packages.

This is now ready to be merged if you are fine with it @jdchristensen.

@Alizter
Copy link
Collaborator Author

Alizter commented Jun 9, 2024

I noticed you wrote LGTM before so I will take this as a green light and proceed.

@Alizter Alizter merged commit 8856a2a into HoTT:master Jun 9, 2024
22 checks passed
@Alizter Alizter deleted the ps/rr/bump_min_version_to_8_19 branch June 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants