-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pinch map of suspension #1845
Merged
Alizter
merged 3 commits into
HoTT:master
from
Alizter:ps/branch/pinch_map_of_suspension
Feb 12, 2024
Merged
pinch map of suspension #1845
Alizter
merged 3 commits into
HoTT:master
from
Alizter:ps/branch/pinch_map_of_suspension
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdchristensen
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the minor changes are done.
I also noticed the "necessary" is spelled wrong twice in unchanged comments. Maybe you can fix those while you are editing this file? |
Alizter
force-pushed
the
ps/branch/pinch_map_of_suspension
branch
from
February 12, 2024 21:00
9f0b77f
to
283d936
Compare
@jdchristensen I've addressed your comments now. |
jdchristensen
approved these changes
Feb 12, 2024
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
ps/branch/pinch_map_of_suspension
branch
from
February 12, 2024 21:08
283d936
to
3f26a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We define the pinch map of a suspension and show that it computes accordingly with the wedge projections.