Truncatedness of pointed maps and pForall #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdchristensen
commented
Jan 18, 2024
Comment on lines
+163
to
+164
| (** When combined with [isequiv_oD_to_O], this yields Theorem 7.7.7 in the book. *) | ||
| Definition isequiv_oD_to_O_modality |
There was a problem hiding this comment.
This was simply moved earlier so that the "this" in the comment made sense.
Comment on lines
+75
to
+76
| (** The [&] tells Coq to use the context to infer the later arguments (in this case, all of them). *) | ||
| Arguments Build_pMap & _ _ _ _. |
There was a problem hiding this comment.
This lets us write (Build_pMap _ _ ...) in some cases where Coq insisted that the arguments be filled in.
Comment on lines
-138
to
-139
| Definition pequiv_ptr_functor {X Y : pType} n | ||
| : X <~>* Y -> pTr n X <~>* pTr n Y. |
There was a problem hiding this comment.
We had this result twice.
Alizter
reviewed
Jan 19, 2024
| unfold ExtensionAlong. | ||
| refine (issig_pforall A P oE _). | ||
| apply equiv_functor_sigma_id; intro s. | ||
| symmetry; apply equiv_unit_rec. |
There was a problem hiding this comment.
I checked, and it's probably not possible to remove funext from equiv_unit_rec so the funext will have to stay.
Alizter
reviewed
Jan 19, 2024
Alizter
reviewed
Jan 19, 2024
Alizter
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proves Buchholtz-van Doorn-Rijke, Theorem 4.2 and related things. The first commit has the meat, and can be reviewed on its own. The second commit just contains minor cleanups that I noticed while reading things.