Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: stop spinner before prompt #203

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

kitazaki
Copy link
Contributor

@kitazaki kitazaki commented Jan 1, 2025

Moddable SDK 5.3.3 is released without pre-built binaries. "xs-dev setup" requires the prompt, but it doesn't work in spinner working. #200

Reproduced on mac and linux.
This change fixes the prompt issue.
#201

Moddable SDK 5.3.3 is released without pre-built binaries.
"xs-dev setup" requires the prompt, but it doesn't work in spinner working. 
HipsterBrown#200

Reproduced on mac and linux.
This change fixes the prompt.
Copy link
Owner

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 👍

@HipsterBrown HipsterBrown merged commit 4648979 into HipsterBrown:main Jan 1, 2025
2 checks passed
@HipsterBrown HipsterBrown added the patch Increment the patch version when merged label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

🚀 PR was released in v0.36.2 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jan 1, 2025
@HipsterBrown HipsterBrown linked an issue Jan 1, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The confirm prompt does not show.
2 participants