Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintaining standard Draft 1 #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

curtisblackwell
Copy link
Member

Jordan's old PR (#14) can't be reopened since it's set to merge into master and we deleted that branch when we switched to using main.

I'm checking all the boxes here to match where we left off, but there's still feedback in there that needs to be addressed. @ashabrah seemed like he may be interested in taking over the effort to get this ready for a vote. Is that accurate, Ashish?

Author checklist

  • I'm proposing a single change in this PR.
  • I believe the proposed standard:
    • benefits more than it costs us and
    • doesn't conflict with our people-first value.
  • The standard's file(s) follow(s) the established directory structure.
  • I provided:
    • a succinct summary,
    • reasoning for the proposed change,
    • an example/instructions on how to embody the standard unless repealing, and
    • a longer explanation if appropriate.

Check boxes if requirement met or irrelevant.

First reviewer checklist

NOTE: Some of the author's checklist items are intentionally omitted, because they are a matter of opinion and up for discussion with the whole team.

  • This PR contains a single change.
  • The proposed standard follows the established directory structure.
  • The author provided:
    • a succinct summary,
    • reasoning for the proposed change, and
    • an example/instructions on how to embody the standard unless repealing.

Check boxes if requirement met or irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants