Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various semantic changes in email text, footer, and event page #262

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

grablair
Copy link
Contributor

This is a minor change that modifies some text in emails and in the title of event pages.

  1. It ensures all emails end with the app name, and normalizes the format of that section of the email
  2. Changes the default email footer to "© <year> <app-name> | Powered by Hi.Events" with Hi.Events linked to https://hi.events?utm_source=app-email-footer. My thinking is that the actual content of the email may not be copyrighted to Hi.Events; and it changes the footer to the "Powered by" verbiage, as that's what is in the LICENCE, so it makes it consistent with the license and elsewhere in the code.
  3. Changes the event page title to end with the organizer name instead of "Hi.Events" (i.e. "My Great Event | Cool Theater"). My thinking is that users should clearly know who is organizing the event.

Very open to thoughts on points 2 and 3.

Checklist

  • I have read the contributing guidelines.
  • My code is of good quality and follows the coding standards of the project.
  • I have tested my changes, and they work as expected.

Thank you for your contribution! 🎉

@daveearley
Copy link
Contributor

These changes all make sense to me. Thanks for the PR!

@daveearley daveearley merged commit e05cd1d into HiEventsDev:develop Oct 20, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants