Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File association format #946

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Conversation

rowin-C
Copy link
Contributor

@rowin-C rowin-C commented Dec 2, 2024

  • Installed Tagify package
  • Setup Tagify code in dev-center.js
  • Changed "A comma-separated list of file type specifiers." to "A list of file type specifiers."
  • added function that validates user input before submit and shows error

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ion in dev center
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2024

CLA assistant check
All committers have signed the CLA.

@rowin-C rowin-C closed this Dec 2, 2024
@jelveh
Copy link
Contributor

jelveh commented Dec 2, 2024

Hi @rowin-C , I was about to test your PR. Is a new one coming or should I just go with this?

@rowin-C
Copy link
Contributor Author

rowin-C commented Dec 2, 2024

i removed the unnecessary tagify package , its coming from cdn, im making a new pr now

@rowin-C rowin-C reopened this Dec 2, 2024
@jelveh
Copy link
Contributor

jelveh commented Dec 2, 2024

Hi Rowan, I ran this locally and I love the new tagified input!
Could take a look at the merge conflict before I can proceed with more reviews?

@rowin-C
Copy link
Contributor Author

rowin-C commented Dec 2, 2024

sure I'll look into the conflict and let you know

@jelveh jelveh merged commit f0d1de7 into HeyPuter:main Dec 3, 2024
1 check passed
jelveh added a commit that referenced this pull request Dec 3, 2024
This reverts commit f0d1de7.
jelveh added a commit that referenced this pull request Dec 3, 2024
This reverts commit f0d1de7.
@jelveh
Copy link
Contributor

jelveh commented Dec 3, 2024

Sorry I merged this by accident. I'm still testing. Getting syntax errors when opening dev center

@rowin-C rowin-C deleted the fileAssociationFormat branch December 3, 2024 15:46
@rowin-C rowin-C restored the fileAssociationFormat branch December 3, 2024 15:46
@rowin-C
Copy link
Contributor Author

rowin-C commented Dec 3, 2024

Can you show me the error , then I'll try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants