Preparation for adding a service manager to puter.js #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ServiceManager will replace manual management of services within initgui, and will also be used within puter.js. Eventually Puter's backend might use this instead of the existing Container class, although this will be a large change that needs to be done incrementally. The difference between ServiceManager and Container is the logic behind when initialization occurs. Rather than have all services initialized at once when Container's init() method is called, services are initialized as soon as their dependencies have been initialized.
Dispatching and listening to events is non-trivial. The apparent triviality is in implementing a list of listeners and calling them. The non-triviality is in the nature of what happens to a system when it has multiple different interfaces to register listeners and publish events. This commit adds TopicsFeature, which allows any class extending AdvancedBase to declare topics. A topic is a simple pub/sub channel. TopicsFeature will manage the state of listeners so the class doesn't need to. A GC-friendly mechanism for detaching listeners is also provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service pattern has proven incredibly useful. This implements a new services registry for later use in puter.js, putting a lot of common functionality into
putilitywhere it can also be used in backend. Also in this PR is an implementation of a generic way to provide listenable events on a class (called "topics"), that lack of which has been a pain point up until now.These additions in
putilityalso further established how traits are used. Using traits instead of imaginary interfaces will improve readability (specifically the ability to find what files/classes are involved in a particular behavior) as well as make name collisions with methods impossible..mixin()is also now provided by TraitsFeature, which is effectively an implementation of mixins without the drawback of name collisions because it's working on top of traits.